Update proxy names #2323
Update proxy names #2323
Conversation
| @@ -44,18 +44,18 @@ const PROXY_TYPES: Record<NonNullable<SmartContractProxyType>, { | |||
| link: 'https://github.com/wighawag/clones-with-immutable-args', | |||
| }, | |||
| master_copy: { | |||
| name: 'GnosisSafe', | |||
| name: 'Safe proxy', | |||
There was a problem hiding this comment.
I'm voting for the second variant with "standard" or "pattern" word at the end (e.g., 'Safe proxy standard' or 'Safe proxy pattern'). Imho, "This proxy contract is detected via Safe proxy pattern" would be more descriptive. And the same goes with Compound protocol, imo
There was a problem hiding this comment.
What do you think about EIP-based proxies? I've decided to keep "Safe proxy" for consistency, because we don't write "EIP-1167 pattern". I think if we decide to use word "pattern", then it should be added for all variants.
There was a problem hiding this comment.
"EIP-1167 pattern" looks fine for me
There was a problem hiding this comment.
In general, though, I'm not sure, that the word "pattern" is necessary in case of EIPs, even if we decide to use it for non-EIP patterns. In my understanding, the word "EIP" implies that it is a standard by itself, while "Safe proxy" does not
Description and Related Issue(s)
Update displayed proxy names
Checklist for PR author