This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Update macOS native code to Swift 4.0 #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hstove
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
LGTM - I ran the local build script and got the native app with no errors. Seems to be good. Please advise if there is more testing I should be doing.
I'm curious how you came to do this - were you blocked by needing to upgrade? Just good practice? I see that Swift 5 is out and has an auto-upgrade process in Xcode.
|
Yes, the upgrade is blocking a release since the latest version of xcode deprecated support for swift 3.0. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update macOS native code to Swift 4.0 so that new builds can be made with xcode 10.1+, since Apple has deprecated support for Swift 3.0 in newer xcode versions. PR changes Swift compiler version to 4.0 and updates deprecated syntax to Swift 4.0.