-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tag and additional status labels to Image Card component #1402
Labels
sf request
Changes requested by the DAHLIA team
Comments
@seanmalbert Have a look and let me know your thoughts. |
slowbot
changed the title
Add property hero label, additional date banners to listing images
Add tag and additional status labels to Image Card component
Jun 30, 2021
@akegan See my proposal spec |
I don't seem to be able to assign him to the ticket, but Anthony (@aekong) from our team is looking to pick up this ticket. He'll start with the mockups from Jesse in the ticket, but @seanmalbert let us know if you have any thoughts on it! |
27 tasks
27 tasks
23 tasks
Can be QAd in storybook. |
@akegan Yes to your first question. Use warning variation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Jira ticket for hero label, and for date banner
Goal
As a user I want to see high level details about a listing as part of the listing summary
Updated Properties
Property | Description | Variants
------------ | ------------- | --- | -----
Status Label | presents listing status | should be extended to support multiple dates for specific statuses
Tag | display community type |
Mockups
Property Hero
Context
I've combined these two because they both seem like they're variations on the image card component that you have.
Property hero label
On DAHLIA, we have this orange tag for reserved buildings on the listing dir page:
We also have it on the listing details page, with a slightly different positioning:
Do bloom folks want this pattern? Do you already have it in progress? Do you have a similar component that we could re-use to include as a variation on the Image Card component
Multiple date banners
We have a couple of different states for our listing dir page that don't seem to be covered in the image card or "Application Status" components that you have
In between applications closing and the lottery being run, we show both states:
After the lottery has been run, we just show lottery results posted:
It seems like the ApplicationStatus component includes the logic of what to show, I'm wondering if we can extend that, or if we need to pull that logic out of the image card component to make it a bit more customizable.
Another note: Since we've been around a while and we have lots of long-running lease-ups, we've found the need to include the year in the date if the date is from a previous calendar year, is that a change you're up for including?
The text was updated successfully, but these errors were encountered: