Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag and additional status labels to Image Card component #1402

Closed
akegan opened this issue Jun 23, 2021 · 8 comments
Closed

Add tag and additional status labels to Image Card component #1402

akegan opened this issue Jun 23, 2021 · 8 comments
Assignees
Labels
sf request Changes requested by the DAHLIA team

Comments

@akegan
Copy link
Contributor

akegan commented Jun 23, 2021

Jira ticket for hero label, and for date banner

Goal

As a user I want to see high level details about a listing as part of the listing summary

Updated Properties

Property | Description | Variants
------------ | ------------- | --- | -----
Status Label | presents listing status | should be extended to support multiple dates for specific statuses
Tag | display community type |

Mockups
Property Hero

image

Context

I've combined these two because they both seem like they're variations on the image card component that you have.

Property hero label

On DAHLIA, we have this orange tag for reserved buildings on the listing dir page:
image
We also have it on the listing details page, with a slightly different positioning:
image

Do bloom folks want this pattern? Do you already have it in progress? Do you have a similar component that we could re-use to include as a variation on the Image Card component

Multiple date banners

We have a couple of different states for our listing dir page that don't seem to be covered in the image card or "Application Status" components that you have

In between applications closing and the lottery being run, we show both states:
image
After the lottery has been run, we just show lottery results posted:
image

It seems like the ApplicationStatus component includes the logic of what to show, I'm wondering if we can extend that, or if we need to pull that logic out of the image card component to make it a bit more customizable.

Another note: Since we've been around a while and we have lots of long-running lease-ups, we've found the need to include the year in the date if the date is from a previous calendar year, is that a change you're up for including?
image

@akegan akegan added the sf request Changes requested by the DAHLIA team label Jun 23, 2021
@slowbot
Copy link
Collaborator

slowbot commented Jun 28, 2021

@akegan

  1. Hero labels make sense and we have a tag component we could extend for this https://storybook.bloom.exygy.dev/?path=/story/text-tag--standard
  2. Multiple date banners, this makes sense. we should be explicit and define each of the statuses
    • Open
    • Awaiting Results (Pre Lottery)
    • Results Posted (Post Lottery)
  3. Extending the date to include the year makes sense

@seanmalbert Have a look and let me know your thoughts.

@slowbot slowbot changed the title Add property hero label, additional date banners to listing images Add tag and additional status labels to Image Card component Jun 30, 2021
@slowbot
Copy link
Collaborator

slowbot commented Jun 30, 2021

@akegan See my proposal spec

@akegan
Copy link
Contributor Author

akegan commented Jun 30, 2021

looks good to me! Do you have a different component for the directory image and the details image? The details component for us has everything centered, with no subtitle or banner. Wondering if you use the same or a different component for that
image

@akegan akegan assigned seanmalbert and unassigned seanmalbert Jul 2, 2021
@akegan
Copy link
Contributor Author

akegan commented Jul 2, 2021

I don't seem to be able to assign him to the ticket, but Anthony (@aekong) from our team is looking to pick up this ticket. He'll start with the mockups from Jesse in the ticket, but @seanmalbert let us know if you have any thoughts on it!

@akegan
Copy link
Contributor Author

akegan commented Jul 7, 2021

@slowbot, on the topic of a11y, @aekong just implemented this variation with the shade of orange but it only has a color contrast of 2.92.

should we use the warning variation instead?
image
Or maybe accent-warm-light?
image
Those both look like they're passing in the a11y tab

@seanmalbert
Copy link
Collaborator

Can be QAd in storybook.

@emilyjablonski
Copy link
Collaborator

@slowbot
Copy link
Collaborator

slowbot commented Sep 10, 2021

@akegan Yes to your first question. Use warning variation

@slowbot slowbot removed the ready for qa Ready to be QA’d label Sep 10, 2021
@slowbot slowbot closed this as completed Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sf request Changes requested by the DAHLIA team
Projects
None yet
Development

No branches or pull requests

4 participants