Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ui-component for Action Block component #1404

Closed
akegan opened this issue Jun 23, 2021 · 6 comments
Closed

Add ui-component for Action Block component #1404

akegan opened this issue Jun 23, 2021 · 6 comments
Assignees
Labels
sf request Changes requested by the DAHLIA team

Comments

@akegan
Copy link
Contributor

akegan commented Jun 23, 2021

DAHLIA Jira ticket
DAHLIA Jira ticket

Goal

As a user I want to see high value actions treated with emphasis

Properties

Property Description Variants Required
Heading component heading h2 (default), possibly add prop to change tag Yes
Heading Size heading text size 1.25 rem (default) or 2rem No
Action button single (default) or multiple actions , possibly add ability to add button styles to designate hierarchy No
Icon png or svg icon, should have alt tag or title for accessibility Boolean No
Layout alignment block, stacks and centers elements (default), has additional vertical padding, inline, layout out elements horizontally No
Background background color none (default), primary-lighter, or primary darker (see if we can use tailwind dark mode for this) No

Mockups
Action Block
Action Block, Inline variant

image
image

Context

Use Case 1
At the end of our directory pages, we use this component to direct people to sign up for our mailing list.

Mobile: image
Desktop: image

Is this a component that bloom would be interested in? Any preferences around implementation?

Use Case 2
On our rental and sale directories, we have a banner right after active listings to help direct users to other opportunities for affordable listings. We use a variation with one button for rentals, and one with two buttons for sales.

Single button desktop:
image

Single button mobile:
image

Two button desktop:
image

Two button mobile:
image

Our acceptance criteria:

  • Component is created and matches styling from angular
  • Component has an option of 1 or 2 buttons, with text size that varies based on that fact
  • The components are responsive and work for mobile screens.

Is this a component that your team would be interested in? Any thoughts or preferences on how to implement it?

@akegan akegan added the sf request Changes requested by the DAHLIA team label Jun 23, 2021
@slowbot
Copy link
Collaborator

slowbot commented Jun 28, 2021

@akegan

We are interested in implementing this component.

  • Icon should be customizable
  • Should support one or more buttons
  • Should have a light and dark (inverted) version

@seanmalbert I can generate some mockups for this

@slowbot slowbot changed the title Add ui-component for email sign-up block Add ui-component for Action Block component Jun 29, 2021
@slowbot
Copy link
Collaborator

slowbot commented Jun 29, 2021

@akegan Moved story details here @software-project

@akegan
Copy link
Contributor Author

akegan commented Jun 29, 2021

@slowbot, 2 questions:

  1. In our component, we have the text slightly bigger for the single button case to give it a bit of a nicer scale, is that something that you'd be up for?
  2. With these cases, you have the same text on the buttons, but ideally we want the 2 buttons to have the same width even if the text in the buttons is different, can you add some details about the width of the buttons and how they should behave? Edit: I just checked DAHLIA and actually the buttons are not the same width!
    image

@slowbot
Copy link
Collaborator

slowbot commented Jun 29, 2021

@akegan We can handle that with a variant. "Heading size"

@akegan
Copy link
Contributor Author

akegan commented Dec 29, 2021

Closing because this was implemented a while ago. Follow-up to fix a bug is in #2171

@emilyjablonski
Copy link
Collaborator

emilyjablonski commented Aug 23, 2023

Component implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sf request Changes requested by the DAHLIA team
Projects
None yet
Development

No branches or pull requests

4 participants