Listing Mgmt Validations: Add required label to listings management

[kathyccheng]

As a leasing agent,
I want to know which fields are required to publish
So that I have a sense of what information is most important for me to gather

Acceptance Criteria

• When I am on the listings mgmt edit page, see required labels next to all of the required fields
• When I am on the listing mgmt page, then I'll see required labels next to the entire field sets that are required

Notes

• This is just helper text, we're not checking anything in this issue
• We can use the publish required fields to generate the labels

Design Notes

• When there is existing helper text, ensure the Required text breaks to a new line
  

• For blank slate "repeater" elements, we should add a field label or legend to ensure the error text is associated with the element
  

• All address fields should have a fieldset legend or field group label to associate the required text with (I think all addresses in LM have this except the Building Address
  

Links
Required Fields:
https://docs.google.com/spreadsheets/u/1/d/1yzy7t1n0lNuhjmElnBH7rFOk2qZYdK7iHwhnyY3QrmM/edit#gid=515768701

Designs:
https://www.figma.com/file/Y8bFd0aSz7eYJ2TCNid6s3/bloom-partners?node-id=4153%3A170749

[kathyccheng]

@slowbot consider "Required to Publish"

[seanmalbert]

The validation handling itself should be handled by 1541/1542, but there are some updates needed in how these are displayed with "groups" of fields as demonstrated in the mocks above.

[emilyjablonski]

@kathyccheng @slowbot Should I move forward with Required or Required to Publish ?

[kathyccheng]

@slowbot to decide

[slowbot]

@emilyjablonski I'm fine with "Required to publish"

[emilyjablonski]

Ensure all fields that are required on publish have the label and that they play nicely with the error messages.

[slowbot]

@emilyjablonski

@kathyccheng Feel free to push back on this and we can create another ticket for the aria labels

Required to publish labels need to be associated with the fields or fieldsets they are labeling.

• At minimum we need to use aria-describedby and an associated ID
  • https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques/Using_the_aria-describedby_attribute

New ticket:

• We can create another ticket to handle fieldsets, but in the future we should look at a way to wrap address fields in a fieldset we can associate labels and errors

[kathyccheng]

@slowbot is the main issue around the aria labels for accessibility or the field sets, or are they inter-related? Regardless, I'd say let's create a new issue

[slowbot]

Both are accessibility issues. Fieldsets are technically more complex. Aria labels seem less complex and sort of necessary otherwise it's just text on the page and doesn't relate to anything.