Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partners Invite - Admin - Edit User #1655

Closed
kathyccheng opened this issue Aug 11, 2021 · 5 comments
Closed

Partners Invite - Admin - Edit User #1655

kathyccheng opened this issue Aug 11, 2021 · 5 comments
Labels
ready for qa Ready to be QA’d

Comments

@kathyccheng
Copy link
Collaborator

kathyccheng commented Aug 11, 2021

As an admin,
I might want to edit a user's information
So that I can make changes if something needs to be changed

Acceptance Criteria

  • When I am on the users table, then I will see a link on the user's name
  • When I click on that link, I will be taken to an Edit Screen
  • When I change listings access, then the leasing agent will see those changes reflected in their dashboard
  • When I change Name or Email, the changes will be saved
  • When I click Resend Invite, then another invite email will be sent
  • When I click Delete User, then I will see an are you sure modal. If I click yes, then the user will be removed.

Notes

  • Changing name or email, we will not send any notifications of the change for right now
  • Deleting a user is a hard delete

Designs
Unconfirmed
https://www.figma.com/file/Y8bFd0aSz7eYJ2TCNid6s3/bloom-partners?node-id=4084%3A169556
Confirmed
https://www.figma.com/file/Y8bFd0aSz7eYJ2TCNid6s3/bloom-partners?node-id=4388%3A175177
Delete
https://www.figma.com/file/Y8bFd0aSz7eYJ2TCNid6s3/bloom-partners?node-id=4388%3A175282

@slowbot add delete and confirm delete to edit screen

QA Review Notes

  1. Go to https://dev-partners-bloom.netlify.app/users logged in as an admin
  2. click "Add User"
  3. Add the user with the partner role and with an email address you have access to and invite the user
  4. check your email and confirm the invite
  5. set the users password
  6. you should be logged in as that new user and see the listings they were assigned to
  7. update the user's assigned listings in another tab logged in as an admin
  8. the partner user should see the listing list updated
@kathyccheng kathyccheng changed the title Admin Edit User Admin - Edit User Aug 11, 2021
@kathyccheng kathyccheng changed the title Admin - Edit User Partners Invite - Admin - Edit User Aug 25, 2021
@seanmalbert
Copy link
Collaborator

@pbn4 to update with notes for backend updates. We will split off another issue to handle the frontend.

@pbn4
Copy link
Contributor

pbn4 commented Sep 9, 2021

Backend work:

  • move user editing his own profile to an endpoint like PUT /me
  • create a new PUT /users/:id for admins only and enable editing any user related property there

@dominikx96
Copy link
Collaborator

@kathyccheng @seanmalbert , as we talked on the standup - here, is a problem with lack of jurisdiction for a user.

@seanmalbert
Copy link
Collaborator

seanmalbert commented Nov 9, 2021

This is currently blocked by #2045, because the backend is currently using redis to cache listings and the cache is served up regardless if it's public or partners. This prevents a full QA of this feature, because if you edit the listings a user has access to, that does not currently clear the cache. This issue is resolved by 2045, because we will no longer be hitting the cache from partners once that is implemented.

The ready for qa label should be applied and review instructions added, once this is unblocked

@kathyccheng kathyccheng added the blocked Further development is blocked waiting for something external to this ticket label Nov 18, 2021
@seanmalbert seanmalbert added ready for qa Ready to be QA’d and removed blocked Further development is blocked waiting for something external to this ticket labels Nov 30, 2021
@kathyccheng
Copy link
Collaborator Author

Looks good, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for qa Ready to be QA’d
Projects
None yet
Development

No branches or pull requests

4 participants