From 36dc0f7690529792b6ca7a7121b2506094c33ded Mon Sep 17 00:00:00 2001
From: Clay Baenziger <cbaenziger@bloomberg.net>
Date: Thu, 1 Nov 2018 21:11:43 -0400
Subject: [PATCH] Code-Review Requests

---
 cookbooks/bcpc/recipes/pam.rb                           | 2 +-
 cookbooks/bcpc/templates/default/pam_namespace.init.erb | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/cookbooks/bcpc/recipes/pam.rb b/cookbooks/bcpc/recipes/pam.rb
index 564d281c1..16ed50b27 100644
--- a/cookbooks/bcpc/recipes/pam.rb
+++ b/cookbooks/bcpc/recipes/pam.rb
@@ -46,7 +46,7 @@
   source 'pam_namespace.conf.erb'
   mode 500
   variables(lazy {{ real_home_dir_users:
-                     node['bcpc']['pam_namespace']['real_home_dir_users'].join(','),
+                     node['bcpc']['pam_namespace']['real_home_dir_users'].uniq.sort.join(','),
                    shm_polyinstantion_dir: shm_polyinstantion_dir,
                    polyinstantion_dir: polyinstantion_dir
                  }})
diff --git a/cookbooks/bcpc/templates/default/pam_namespace.init.erb b/cookbooks/bcpc/templates/default/pam_namespace.init.erb
index 67d4aa2d2..2b5d588cc 100644
--- a/cookbooks/bcpc/templates/default/pam_namespace.init.erb
+++ b/cookbooks/bcpc/templates/default/pam_namespace.init.erb
@@ -1,4 +1,8 @@
 #!/bin/sh
+
+# This script provided from Ubuntu Bug 1081323.
+# Please remove for the distribution upstream once using pam - 1.1.8-3.6ubuntu1 (Bionic) or better
+
 # It receives polydir path as $1, the instance path as $2,
 # a flag whether the instance dir was newly created (0 - no, 1 - yes) in $3,
 # and user name in $4.