New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove --self flag #140

Closed

alicederyn opened this issue Aug 23, 2023 · 0 comments · Fixed by #141

Contributor

alicederyn commented Aug 23, 2023 •

edited

Loading

Originally posted by @godlygeek in #139 (comment)

I think we should probably just remove this flag. It isn't exercised by our tests, and it appears to have bit rotted:

$ pystack --self
usage: pystack [-h] [-v] [--no-color] {remote,core} ...
pystack: error: the following arguments are required: command
$ pystack --self remote
usage: pystack remote [-h] [-v] [--no-color] [--no-block] [--native] [--native-all] [--locals] [--exhaustive] [--self] pid
pystack remote: error: the following arguments are required: pid

I think we removed the code for handling this flag at some point, and missed removing the flag itself.

@alicederyn Would you be interested in updating the PR to remove all mentions of --self instead?

The text was updated successfully, but these errors were encountered:

alicederyn mentioned this issue

Remove --self flag #141

Merged

pablogsal closed this as completed in #141

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment