Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make clean breaks virtualenvs stored inside the repo clone #56

Closed
godlygeek opened this issue Apr 23, 2023 · 3 comments · Fixed by #74
Closed

make clean breaks virtualenvs stored inside the repo clone #56

godlygeek opened this issue Apr 23, 2023 · 3 comments · Fixed by #74
Assignees
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@godlygeek
Copy link
Contributor

If you create a virtualenv inside a clone of the repo, running make clean will break it by removing all of the *.so files inside of it. We should improve our make clean to only remove files that we know we've created.

@godlygeek godlygeek added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Apr 23, 2023
@Helithumper
Copy link
Contributor

I believe this could be fixed with just a find . -not -path $VIRTUAL_ENV in the first line of the clean target, however would there be another case where there may be files we would not want to clean up?

@godlygeek
Copy link
Contributor Author

It's a bit trickier than that, since you might have multiple virtualenvs all in the same repo root. What you're proposing would stop it from breaking the active virtualenv, but wouldn't stop it from breaking deactivated ones.

The safer option is enumerating the files that we expect to be created by commands in the makefile, and only removing those, rather than using a recursive wildcard.

@jayybhatt
Copy link
Contributor

I'll take this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants