Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rpm-ostree): Remove optfix workaround, when upstream optfix is merged #112

Open
xynydev opened this issue Feb 3, 2024 · 7 comments
Labels
priority: medium Needs to be done soon state: approved Approved to proceed. type: chore Converting measurements, reorganizing folder structure, and less impactful tasks. type: fix Iterations on existing features or infrastructure.

Comments

@xynydev
Copy link
Member

xynydev commented Feb 3, 2024

this issue is now closed: coreos/rpm-ostree#233

@xynydev
Copy link
Member Author

xynydev commented Feb 4, 2024

Not part of the latest release, but will be able to remove optfix once rpm-ostree gets a new release and we get it on our systems. So, once version hits 2024.3 or bigger.

Mine is currently at 2023.11:

❯ rpm-ostree --version
rpm-ostree:
 Version: '2023.11'
 Git: d15b73c58879a43456d5eeeee6605f7524e9ae65
 Features:
  - rust
  - compose
  - container
  - fedora-integration

@xynydev xynydev added type: chore Converting measurements, reorganizing folder structure, and less impactful tasks. state: blocked Something is blocking action. upstream and removed upstream labels Mar 8, 2024
@fiftydinar
Copy link
Collaborator

This is my version since today:

❯ rpm-ostree --version
rpm-ostree:
 Version: '2024.3'
 Git: 1292241492a3476cb36515812ba4eb1f87b8742f
 Features:
  - rust
  - compose
  - container
  - fedora-integration

@fiftydinar fiftydinar changed the title might be able to remove optfix now chore(rpm-ostree): Remove optfix workaround, when upstream optfix is merged Mar 16, 2024
@xynydev
Copy link
Member Author

xynydev commented Mar 16, 2024

My system is not yet updated, but I guess we can go ahead and remove this now, as it doesn't seem to be working correctly for all users, and newer image builds would supposedly have the newer rpm-ostree version as well.

rpm-ostree now has experimental support for installing RPMs with files in /opt and /usr/local. This can be enabled at compose time (via the opt-usrlocal-overlays switch), or client-side using coreos/rpm-ostree#233 (comment). Feedback on the approach would be greatly appreciated! coreos/rpm-ostree#4728
(from https://github.com/coreos/rpm-ostree/releases/tag/v2024.3)

We would have to figure out how to enable the experimental support, and do that by default.

@xynydev
Copy link
Member Author

xynydev commented May 5, 2024

Moving discussion from #165 .

Upstream issues to enable opt-usrlocal-overlays by default:

Both of these seem stagnant. I'll poke em a little.

@xynydev
Copy link
Member Author

xynydev commented Jul 6, 2024

coreos/fedora-coreos-tracker#1681 is now closed as wontfix. (it was apparently just left open for long after the matter had settled, so the latest changes regarding this were now months ago in v2024.3)

There is a way to set the existing opt thing as an environment variable for rpm-ostree: coreos/rpm-ostree#233 (comment)

I think we could leave the experimental opt option off, unless optfix: is declared to be anything other than false.

@xynydev xynydev added type: fix Iterations on existing features or infrastructure. state: approved Approved to proceed. priority: medium Needs to be done soon and removed state: blocked Something is blocking action. labels Jul 6, 2024
@fiftydinar
Copy link
Collaborator

There is a way to set the existing opt thing as an environment variable for rpm-ostree: coreos/rpm-ostree#233 (comment)

I think we could leave the experimental opt option off, unless optfix: is declared to be anything other than false.

The issue with this is that his method only works on booted system, not in build-time.
At least last time I tried.

@xynydev
Copy link
Member Author

xynydev commented Jul 6, 2024

Ah, well, that's what I feared when I saw this comment: coreos/rpm-ostree#4728 (comment)

There's not much use for this feature if not available at build-time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Needs to be done soon state: approved Approved to proceed. type: chore Converting measurements, reorganizing folder structure, and less impactful tasks. type: fix Iterations on existing features or infrastructure.
Projects
None yet
Development

No branches or pull requests

2 participants