Suggesting specifc Create Inspector return type for call call_end

[mattsse]

While it is possible and perhaps desired to override the address:

revm/crates/revm/src/inspector.rs

Line 134 in 3608d2d

) -> (InterpreterResult, Option<Address>) {

most of the time it is not needed.

Since we already made changes to the Inspector, I'm suggesting to make this return type a bit easier as well like

struct CreateOutcome {result: InterpreterResult, address: Option<Address>}

and some helper functions like CreateOutcome::continue() -> Self

what's the difference between the Option here:

revm/crates/revm/src/inspector.rs

Lines 114 to 118 in 3608d2d

	fn create(
	&mut self,
	context: &mut EvmContext<'_, DB>,
	inputs: &mut CreateInputs,
	) -> Option<(InterpreterResult, Option<Address>)> {

and non optional here:

revm/crates/revm/src/inspector.rs

Lines 129 to 134 in 3608d2d

	fn create_end(
	&mut self,
	context: &mut EvmContext<'_, DB>,
	result: InterpreterResult,
	address: Option<Address>,
	) -> (InterpreterResult, Option<Address>) {

[loocapro]

May I take this?

[rakita]

Can you do it on top of the external_field branch? There are a few conflicting changes there

[loocapro]

Sure!

[mahmudsudo]

has this been taken already

[loocapro]

has this been taken already

Yes sorry.

[rakita]

done