diff --git a/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc b/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc index 123c6ef7166b79..24472755f6c623 100644 --- a/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc +++ b/third_party/blink/renderer/platform/loader/fetch/resource_fetcher.cc @@ -928,11 +928,6 @@ void ResourceFetcher::UpdateMemoryCacheStats( RecordResourceHistogram("Preload.", factory.GetType(), policy); } else { RecordResourceHistogram("", factory.GetType(), policy); - - // Log metrics to evaluate effectiveness of the memory cache if it was - // partitioned by the top-frame site. - if (same_top_frame_site_resource_cached) - RecordResourceHistogram("PerTopFrameSite.", factory.GetType(), policy); } // Aims to count Resource only referenced from MemoryCache (i.e. what would be diff --git a/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc b/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc index 29183ff9c72e44..d5993c04a569dd 100644 --- a/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc +++ b/third_party/blink/renderer/platform/loader/fetch/resource_fetcher_test.cc @@ -386,9 +386,6 @@ TEST_F(ResourceFetcherTest, MetricsPerTopFrameSite) { EXPECT_EQ(resource_1, resource_2); // Test histograms. - histogram_tester.ExpectTotalCount( - "Blink.MemoryCache.RevalidationPolicy.PerTopFrameSite.Mock", 0); - histogram_tester.ExpectTotalCount("Blink.MemoryCache.RevalidationPolicy.Mock", 2); @@ -400,7 +397,7 @@ TEST_F(ResourceFetcherTest, MetricsPerTopFrameSite) { 0 /* RevalidationPolicy::kUse */, 1); // Now load the same resource with origin_b as top-frame site. The - // PerTopFrameSite histogram should be incremented. + // histograms should be incremented. auto* fetcher_3 = CreateFetcher(); ResourceRequestHead request_head_3(url); scoped_refptr foo_origin_b = @@ -412,11 +409,6 @@ TEST_F(ResourceFetcherTest, MetricsPerTopFrameSite) { Resource* resource_3 = MockResource::Fetch(fetch_params_2, fetcher_3, nullptr); EXPECT_EQ(resource_1, resource_3); - histogram_tester.ExpectTotalCount( - "Blink.MemoryCache.RevalidationPolicy.PerTopFrameSite.Mock", 1); - histogram_tester.ExpectBucketCount( - "Blink.MemoryCache.RevalidationPolicy.PerTopFrameSite.Mock", - 0 /* RevalidationPolicy::kUse */, 1); histogram_tester.ExpectTotalCount("Blink.MemoryCache.RevalidationPolicy.Mock", 3); histogram_tester.ExpectBucketCount( @@ -465,9 +457,6 @@ TEST_F(ResourceFetcherTest, MetricsPerTopFrameSiteOpaqueOrigins) { EXPECT_EQ(resource_1, resource_2); // Test histograms. - histogram_tester.ExpectTotalCount( - "Blink.MemoryCache.RevalidationPolicy.PerTopFrameSite.Mock", 0); - histogram_tester.ExpectTotalCount("Blink.MemoryCache.RevalidationPolicy.Mock", 2); @@ -479,7 +468,7 @@ TEST_F(ResourceFetcherTest, MetricsPerTopFrameSiteOpaqueOrigins) { 0 /* RevalidationPolicy::kUse */, 1); // Now load the same resource with opaque_origin1 as top-frame site. The - // PerTopFrameSite histogram should be incremented. + // histograms should be incremented. auto* fetcher_3 = CreateFetcher(); ResourceRequestHead request_head_3(url); request_head_3.SetTopFrameOrigin(opaque_origin2); @@ -489,11 +478,6 @@ TEST_F(ResourceFetcherTest, MetricsPerTopFrameSiteOpaqueOrigins) { Resource* resource_3 = MockResource::Fetch(fetch_params_2, fetcher_3, nullptr); EXPECT_EQ(resource_1, resource_3); - histogram_tester.ExpectTotalCount( - "Blink.MemoryCache.RevalidationPolicy.PerTopFrameSite.Mock", 1); - histogram_tester.ExpectBucketCount( - "Blink.MemoryCache.RevalidationPolicy.PerTopFrameSite.Mock", - 0 /* RevalidationPolicy::kUse */, 1); histogram_tester.ExpectTotalCount("Blink.MemoryCache.RevalidationPolicy.Mock", 3); histogram_tester.ExpectBucketCount( diff --git a/tools/metrics/histograms/metadata/blink/histograms.xml b/tools/metrics/histograms/metadata/blink/histograms.xml index cf3e8aa8da09d3..22fe1e708ac12c 100644 --- a/tools/metrics/histograms/metadata/blink/histograms.xml +++ b/tools/metrics/histograms/metadata/blink/histograms.xml @@ -2457,19 +2457,6 @@ chromium-metrics-reviews@google.com. - - shivanisha@chromium.org - privacy-sandbox-dev@chromium.org - - RevalidationPolicy used for requests for each resource type. Logged only if - the resource is found in the memory cache and if the same top-frame site had - loaded this resource earlier. - - - - hiroshige@chromium.org