Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(iOS): Default to speaker instead of earpiece on iOS #1408

Merged
merged 1 commit into from
Jan 29, 2023
Merged

fix(iOS): Default to speaker instead of earpiece on iOS #1408

merged 1 commit into from
Jan 29, 2023

Conversation

spydon
Copy link
Member

@spydon spydon commented Jan 29, 2023 •
edited by Gustl22
Loading

Description

I haven't tried this on a real device so it's quite a shot in the dark.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • No, this is not a breaking change.

Related Issues

Closes #1194

@spydon spydon requested review from luanpotter and Gustl22 January 29, 2023 01:11
luanpotter
luanpotter approved these changes Jan 29, 2023
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but also doesnt have an ios device to test IRL

@Gustl22 Gustl22 changed the title fix: Default to speaker instead of earpiece on iOS fix(iOS): Default to speaker instead of earpiece on iOS Jan 29, 2023
@Gustl22 Gustl22 merged commit 4ea5907 into main Jan 29, 2023
@Gustl22 Gustl22 deleted the spydon/maybe-fix-ios-speaker branch January 29, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gustl22 Gustl22 Gustl22 approved these changes

@luanpotter luanpotter luanpotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iOS volume very low (sound is coming from earpiece)
3 participants
@spydon @luanpotter @Gustl22