Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): Add AGP 8 support with namespace property #1514

Merged
merged 5 commits into from
May 23, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented May 19, 2023

Description

Cherry-pick of #1503

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs:, chore: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Optional Migration instructions

You can upgrade your Android project to use AGP 8. In your android/build.gradle :

buildscript {
  // ...
  dependencies {
    classpath 'com.android.tools.build:gradle:8.0.1'
    // ...
  }
}

If doing so, also don't forget to add a namespace in the android section of android/app/build.gradle :

android {
  // ...
  namespace 'your.namespace'
}

Then can also remove the package property in your android/app/src/main/AndroidManifest.xml

Related Issues

#1503

@Gustl22 Gustl22 requested a review from spydon May 22, 2023 12:59
@Gustl22 Gustl22 merged commit 8d7b322 into main May 23, 2023
@Gustl22 Gustl22 deleted the gustl22/agp8-support branch May 23, 2023 06:43
Gustl22 added a commit that referenced this pull request Jul 20, 2023
…o build.gradle (#1503)

# Description

* Add support for AGP 8 in example
* Set kotlinOptions & compileOptions: sourceCompatibility and targetCompatibility
* Bump version of core-ktx

## Related Issues

#1514

---------

Co-authored-by: Gustl22 <git@reb0.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants