Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ios): Improved AudioContextConfig assertions, fix example #1619

Merged
merged 3 commits into from
Aug 29, 2023
Merged

feat(ios): Improved AudioContextConfig assertions, fix example #1619

merged 3 commits into from
Aug 29, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Aug 27, 2023 •
edited
Loading

Description

  • Improve assertion error messages for AudioContextConfig for values set on iOS
  • Fix example, as it could and should not alternate the options array for AudioContextIOS
  • Improve example to show assertion errors as toast to the user

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@Gustl22 Gustl22 marked this pull request as ready for review August 28, 2023 22:12
@Gustl22 Gustl22 changed the title feat(ios): improved AudioContextConfig errors, fix example feat(ios): improved AudioContextConfig assertions, fix example Aug 28, 2023
@Gustl22 Gustl22 changed the title feat(ios): improved AudioContextConfig assertions, fix example feat(ios): Improved AudioContextConfig assertions, fix example Aug 28, 2023
@Gustl22 Gustl22 requested a review from spydon August 28, 2023 22:55
@Gustl22 Gustl22 merged commit df342c5 into main Aug 29, 2023
@Gustl22 Gustl22 deleted the gustl22/fix-ios-context branch August 29, 2023 09:54
Gustl22 added a commit that referenced this pull request Oct 6, 2023
@Gustl22
Revert "feat(ios): Improved AudioContextConfig assertions, fix example (
4893ec4 
#1619)"

This reverts commit df342c5.
This was referenced Nov 14, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gustl22 @spydon