Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improve Docs #1710

Merged
merged 10 commits into from
Nov 25, 2023
Merged

docs: Improve Docs #1710

merged 10 commits into from
Nov 25, 2023

Conversation

Gustl22
Copy link
Collaborator

@Gustl22 Gustl22 commented Nov 24, 2023

Description

Improve the documentation for:

See #1650

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, refactor:,
    docs:, chore:, test:, ci: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation and added dartdoc comments with ///, where necessary.
  • I have updated/added relevant examples in example.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#1650

@Gustl22 Gustl22 marked this pull request as ready for review November 25, 2023 00:24
@Gustl22 Gustl22 requested a review from spydon November 25, 2023 00:41
@Gustl22
Copy link
Collaborator Author

Gustl22 commented Nov 25, 2023

If need to split in multiple Merge Requests, let me know ;D

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🍻

packages/audioplayers/example/example.md Outdated Show resolved Hide resolved
@Gustl22
Copy link
Collaborator Author

Gustl22 commented Nov 25, 2023

Thank you for reviewing. Also I'm not that fluent in english. So I don't mind if you have some bigger proposals.

@spydon
Copy link
Member

spydon commented Nov 25, 2023

Thank you for reviewing. Also I'm not that fluent in english. So I don't mind if you have some bigger proposals.

I think it looks good. :)

Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@Gustl22 Gustl22 merged commit 4208463 into main Nov 25, 2023
7 checks passed
@Gustl22 Gustl22 deleted the 1650-docs branch November 25, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants