Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null safety support #24

Closed
lig opened this issue Dec 3, 2020 · 5 comments
Closed

Null safety support #24

lig opened this issue Dec 3, 2020 · 5 comments

Comments

@lig
Copy link

lig commented Dec 3, 2020

I'm going to submit a PR for the null safety support.

It is a common practice to keep such a code in a separate branch, i.e. null-safety, to be able to support the main release in legacy mode whilst the null safety compatible release could be released from its branch.

Please, prepare the branch for null safety support PR.

@lig
Copy link
Author

lig commented Dec 3, 2020

flutter_colorpicker null safety PR: mchome/flutter_colorpicker#36

@lig
Copy link
Author

lig commented Dec 31, 2020

#28 allows releasing the null safety compatible pre-release package

@lig
Copy link
Author

lig commented Jan 8, 2021

@erickzanardo as #28 is merged, could you please release a null safety compatible pre-release version of the package?

@erickzanardo
Copy link
Member

@erickzanardo as #28 is merged, could you please release a null safety compatible pre-release version of the package?

Done https://pub.dev/packages/dashbook/versions/0.1.0-nullsafety.0

@lig
Copy link
Author

lig commented Jan 11, 2021

Thanks! I think this issue could be closed now. Nothing to do here until the main branch changes or null safety goes out of beta.

@lig lig closed this as completed Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants