Fix GcUnsafe2 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are tons of GcUnsafe2 warnings now, using nim-HEAD: ``` nim-heap/binaryheap.nim(45, 4) Warning: 'propFulfilled' is not GC-safe as it performs an indirect call here [GcUnsafe2] h.comp(h.data[indParent], h.data[indChild]) <= 0 ^ nim-heap/binaryheap.nim(86, 6) Warning: 'siftdown' is not GC-safe as it calls 'propFulfilled' [GcUnsafe2] ... ```
cdunn2001
pushed a commit
to bio-nim/nim-falcon
that referenced
this pull request
May 24, 2019
cdunn2001
pushed a commit
to bio-nim/nim-falcon
that referenced
this pull request
May 24, 2019
The "{.gcsafe.}" change might not be needed. The real fix for that
was bluenote10/nim-heap#7
|
Thanks for looking into this. Compilation on travis failed, did it compile for you with the change? Do we have to change the other occurrences of the comp signature as well? Perhaps we can simply introduce a type definition for the callback and use it everywhere. |
Actually, no. Your test fails me for with this change. And |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are tons of GcUnsafe2 warnings now, using nim-HEAD: