Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[security issue] Sentry Auth token exposed in eas.json #630

Closed
TowhidKashem opened this issue May 15, 2023 · 4 comments · Fixed by #639
Closed

[security issue] Sentry Auth token exposed in eas.json #630

TowhidKashem opened this issue May 15, 2023 · 4 comments · Fixed by #639
Labels
bug Something isn't working

Comments

@TowhidKashem
Copy link

Describe the bug

89c975413cd543fbb683b11bec984fc2163d9a77312c41c0b4480a570f3daa65

According to this thread:

expo/sentry-expo#321

you don't want to expose the auth token and use env variables instead. The thread is about using it in app.json but I think it applies here as well since the the security vulnerability is in others knowing the token first and foremost.

To Reproduce

Steps to reproduce the behavior:

  1. Check eas.json
  2. Confirm token is there

Expected behavior

Use env variables that are loaded via dot env where needed and not committed to the repo.

@TowhidKashem TowhidKashem added the bug Something isn't working label May 15, 2023
@alimony
Copy link
Contributor

alimony commented May 15, 2023

You should send potential security issues directly to security@bsky.app rather than opening an issue, per README.

@TowhidKashem
Copy link
Author

You should send potential security issues directly to security@bsky.app rather than opening an issue, per README.

nice catch, I emailed them. Will keep the issue open and they can close it after resolving...

@TowhidKashem TowhidKashem changed the title [security issue] Sentry Auth token exposed in eas.Jon [security issue] Sentry Auth token exposed in eas.json May 15, 2023
@pfrazee
Copy link
Collaborator

pfrazee commented May 16, 2023

Ah lovely -- I was under the impression only public tokens were in the repo. I've deauthorized this auth token. Thanks for raising the issue.

@TowhidKashem
Copy link
Author

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants