Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back in Optional to units #321

Closed
coretl opened this issue Oct 24, 2024 · 0 comments · Fixed by #325
Closed

Add back in Optional to units #321

coretl opened this issue Oct 24, 2024 · 0 comments · Fixed by #325
Assignees

Comments

@coretl
Copy link
Contributor

coretl commented Oct 24, 2024

I may have been to hasty with #313, it would appear that original ophyd makes units=None in the descriptor:

Failed validating 'type' in schema['properties']['configuration']['additionalProperties']['properties']['data_keys']['additionalProperties']['properties']['units']:
    {'title': 'Units',
     'description': 'Engineering units of the value',
     'type': 'string'}

On instance['configuration']['det_old']['data_keys']['det_old_mode']['units']:
    None

We should add back in Optional, just for the units field (precision seems to be fine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants