Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fix DefaultMaxPayloadSize from 2GB to 64GB #307

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

jingjunLi
Copy link
Contributor

@jingjunLi jingjunLi commented Jun 29, 2023

Description

Due to the addition of resumable upload and resumable download functionalities(bnb-chain/greenfield-storage-provider#480 & bnb-chain/greenfield-go-sdk#91 ), we now allow uploading larger files to Greenfield. Therefore, we have increased the value of DefaultMaxPayloadSize from 2GB to 64 GB.

Rationale

This configuration change allows users to upload files with a maximum size of 64GB to Greenfield. The DefaultMaxPayloadSize parameter defines the maximum payload size that can be handled by the system during file uploads.

Example

NA

Changes

NA

Copy link
Contributor

@fynnss fynnss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jingjunLi jingjunLi added the r4r label Jun 29, 2023
@unclezoro unclezoro merged commit 71207e3 into develop Jul 4, 2023
@unclezoro unclezoro deleted the feat-fix-default-max-payload-size branch August 16, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants