Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit sp slash amount and add query api #368

Merged

Conversation

forcodedancing
Copy link
Contributor

Description

This pr will update challenge module for the following changes:

  • limit the slash total amount for single sp during some period
  • return challenge id when submitting challenge
  • add query api for query result of single attested challenge - the result will be cleaned

Rationale

new features

Example

na

Changes

Notable changes:

  • limit the total slash amount for a sp

@forcodedancing
Copy link
Contributor Author

Had run make proto-swagger-gen and it shows no changes locally.

@fynnss
Copy link
Contributor

fynnss commented Jul 25, 2023

Had run make proto-swagger-gen and it shows no changes locally.

ensure the version is the same as the CI

which swagger-combine || npm install -g swagger-combine
which protoc-gen-swagger || go install github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger

2 packages are looking for funding
  run `npm fund` for details
v1.4.0
1.25.0

@forcodedancing
Copy link
Contributor Author

forcodedancing commented Jul 25, 2023

Had run make proto-swagger-gen and it shows no changes locally.

ensure the version is the same as the CI

which swagger-combine || npm install -g swagger-combine
which protoc-gen-swagger || go install github.com/grpc-ecosystem/grpc-gateway/protoc-gen-swagger

2 packages are looking for funding
  run `npm fund` for details
v1.4.0
1.25.0

It seems that I am using newer versions.

make proto-swagger-gen  
/Users/xxx/.nvm/versions/node/v14.20.1/bin/swagger-combine
/Users/xxx/go/bin/protoc-gen-swagger
v1.4.0
1.13.1

@forcodedancing forcodedancing force-pushed the feat/limit_sp_slash_amount branch 2 times, most recently from 2e9b162 to 9171fe9 Compare July 25, 2023 08:08
@forcodedancing
Copy link
Contributor Author

forcodedancing commented Jul 25, 2023

Wait fix in #371

@forcodedancing forcodedancing added this pull request to the merge queue Jul 25, 2023
Merged via the queue into bnb-chain:develop with commit ac31e53 Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants