Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dbcmd: add inspect trie tool #103

Merged
merged 4 commits into from
May 9, 2024
Merged

Conversation

sysvm
Copy link
Contributor

@sysvm sysvm commented Apr 29, 2024

Description

Add inspect trie tool to analysis the trie tree more convenient.

Rationale

N/A

Example

 ./geth db inspect-trie --datadir server/data-seed/ latest 4000

Changes

Notable changes:

  • N/A

@sysvm sysvm added the R4R Ready for review label Apr 29, 2024
will-2012
will-2012 previously approved these changes May 6, 2024
joeylichang
joeylichang previously approved these changes May 6, 2024
@sysvm sysvm dismissed stale reviews from joeylichang and will-2012 via 2edb2e9 May 6, 2024 06:25
@sysvm sysvm force-pushed the feat-inspecttrie branch from 2edb2e9 to baa2b53 Compare May 8, 2024 04:00
@krish-nr krish-nr self-requested a review May 8, 2024 06:52
Copy link
Contributor

@krish-nr krish-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with the author that this feature was picked from a previous implementation but was removed in the recent version. For performance monitoring purposes, we are adding it back in this time.

Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sysvm sysvm merged commit 8da2b2f into bnb-chain:develop May 9, 2024
1 check passed
@sysvm sysvm deleted the feat-inspecttrie branch May 9, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R4R Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants