Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tests that use online requests to use a fake local server. #4

Open
bnogalm opened this issue Mar 22, 2018 · 1 comment
Open

Improve tests that use online requests to use a fake local server. #4

bnogalm opened this issue Mar 22, 2018 · 1 comment
Labels
enhancement help wanted
Milestone
Missing base API ...

Comments

@bnogalm
Copy link
Owner

bnogalm commented Mar 22, 2018

servertest.h and federationtest.h are using resources on internet. Test network and funtracker.site to test submission of transaction and to test federation.

Actualy there is a define "DEFINES += STELLAR_SKIP_LIVE_TESTS" to skip these tests as they may fail.

Would be nice to have a system to test these things offline, against a "fake" server.
@bnogalm bnogalm added this to the Missing base API features milestone Mar 22, 2018
@bnogalm
Copy link
Owner Author

bnogalm commented Mar 29, 2020

In this commit a new "fakeserver" class was instroduced.
ea4f18f
It should be enough to convert live test to offline ones. Could be nice to keep both options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
Missing base API features
Development

No branches or pull requests
1 participant
@bnogalm