Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support destructuring assignment #265

Closed
afinch7 opened this issue Feb 25, 2020 · 7 comments · Fixed by #1406
Closed

Support destructuring assignment #265

afinch7 opened this issue Feb 25, 2020 · 7 comments · Fixed by #1406
Assignees
Labels
E-Medium Medium difficulty problem enhancement New feature or request Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Milestone

Comments

@afinch7
Copy link

afinch7 commented Feb 25, 2020

Support destructuring assignment syntax:

const object = {
  name: "text",
  size: 4,
};

const { name, size } = object;
@Razican Razican added the enhancement New feature or request label Apr 3, 2020
@jasonwilliams jasonwilliams added E-Medium Medium difficulty problem Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com labels Sep 30, 2020
@vapour101
Copy link

I'd like to work on this, if that's good?

@jasonwilliams
Copy link
Member

Go for it @vapour101 !

@vapour101
Copy link

Sorry, seems like I had less time to devote to this than I realised. I'm not going to be able to complete this issue.

@SamuelQZQ
Copy link
Contributor

@afinch7 Could I have a try?

@raskad
Copy link
Member

raskad commented Jul 13, 2021

@SamuelQZQ Are you still working on this? I just started some basic implementation and am currently at +128 tests passing. I think I could pick this up if you are not working on it.

@davimiku you referenced #1324, that seems to implement shorthand syntax for Object Initializers right? I think this issue would be also about Destructuring Binding Patterns. Just to make sure I'm not workin on something you already started.

@davimiku
Copy link
Contributor

@raskad That's correct, #1324 only implements initializing objects with the short-hand notation (on the "right-hand side"), i.e.

const message = "hello"
const obj = { message }

That PR didn't cover destructuring assignment (on the "left-hand side"), so great that you've started! I didn't start / wasn't planning on implementing destructuring assignment.

Maybe if you don't hear from SamuelQZQ try asking a maintainer to change the assignment?

@SamuelQZQ
Copy link
Contributor

@raskad Go ahead. I gave up. Haha.

@Razican Razican assigned raskad and unassigned SamuelQZQ Jul 15, 2021
@Razican Razican added this to the v0.13.0 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-Medium Medium difficulty problem enhancement New feature or request Hacktoberfest Hacktoberfest 2021 - https://hacktoberfest.digitalocean.com
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants