Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI for WASM #408

Closed
Razican opened this issue May 21, 2020 · 1 comment · Fixed by #666
Closed

Add CI for WASM #408

Razican opened this issue May 21, 2020 · 1 comment · Fixed by #666
Labels
E-Easy Easy test Issues and PRs related to the tests. webassembly Anything related to using Boa with WASM
Milestone

Comments

@Razican
Copy link
Member

Razican commented May 21, 2020

We have no checks whatsoever to make sure that the webassembly target is building properly. We should use wasm-pack to at least build it, and maybe to add some tests if it's possible.

@Razican Razican added E-Easy Easy test Issues and PRs related to the tests. webassembly Anything related to using Boa with WASM labels May 21, 2020
@Razican Razican added this to the v0.9.0 milestone May 21, 2020
@tomasol
Copy link

tomasol commented May 30, 2020

Hi, AFAK wasm-pack creates WASM files that can be executed only in a browser or on nodejs. However there are other areas (WASI, interface types) and runtimes like wasmtime which are useful for things like plugins.
I've actually succeeded to run boa using wasmtime, just by creating .Cargo/config with following:

[build]
target="wasm32-wasi"

BTW it produces a warning [1]. The wasm file can be executed:

wasmtime target/wasm32-wasi/debug/boa.wasm

and works as expected. It would be great if this was tested on CI as well.
[1]:

warning: output filename collision.
The bin target `boa` in package `boa_cli v0.8.0 (boa_cli)` has the same output filename as the lib target `boa` in package `Boa v0.8.0 (boa)`.
Colliding filename is: target/wasm32-wasi/debug/deps/boa.wasm
The targets should have unique names.
Consider changing their names to be unique or compiling them separately.
This may become a hard error in the future; see <https://github.com/rust-lang/cargo/issues/6313>.

@Razican Razican modified the milestones: v0.9.0, v0.10.0 Jun 10, 2020
@Razican Razican linked a pull request Sep 2, 2020 that will close this issue
@Razican Razican closed this as completed Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E-Easy Easy test Issues and PRs related to the tests. webassembly Anything related to using Boa with WASM
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants