-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test comments in lexer.rs #47
Comments
@jasonwilliams I'll take this up :) |
@akshay5995 you still interested in taking this? |
I am interested in this. Can I take a try? |
CI failed. I read the lexer code and find out that it actually produces a comment token object which contains the comment string. But you said "single-line and multi-line comments are skipped passed and don't generate any tokens", is that a bug or feature? |
dont get reply yet, I assume this is feature and change tests. |
its a feature, we don't need to generate tokens for comments, they should be ignored. |
if CI fails you can run whatever it does locally
is what failed, so looks like formatting issues |
#134 has been fixed. |
lexer.rs now has a test suite, but testing comments are still missing.
Test would ensure single-line and multi-line comments are skipped passed and don't generate any tokens
Contributing
https://github.com/jasonwilliams/boa/blob/master/CONTRIBUTING.md
The text was updated successfully, but these errors were encountered: