Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract prototype from internal slots #578

Closed
HalidOdat opened this issue Jul 20, 2020 · 0 comments · Fixed by #580
Closed

Extract prototype from internal slots #578

HalidOdat opened this issue Jul 20, 2020 · 0 comments · Fixed by #580
Assignees
Labels
discussion Issues needing more discussion execution Issues or PRs related to code execution performance Performance related changes and issues technical debt
Milestone

Comments

@HalidOdat
Copy link
Member

HalidOdat commented Jul 20, 2020

What is the problem with the current implementation?
The problem is that prototype instance is stored in the internal_slots the internal slots are stored as HashMap<String, Value>, this is slow, every time we want to access prototype we have to do hash lookup and the use it.

Changes:

  • Extract __proto__ to Object, this should optimize prototype chain lookup
@HalidOdat HalidOdat added performance Performance related changes and issues technical debt discussion Issues needing more discussion execution Issues or PRs related to code execution labels Jul 20, 2020
@HalidOdat HalidOdat added this to the v0.10.0 milestone Jul 20, 2020
@HalidOdat HalidOdat self-assigned this Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Issues needing more discussion execution Issues or PRs related to code execution performance Performance related changes and issues technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant