Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix abstract relational comparison operators (<, <=, > and >=) #615

Closed
elasmojs opened this issue Aug 9, 2020 · 1 comment · Fixed by #617
Closed

Fix abstract relational comparison operators (<, <=, > and >=) #615

elasmojs opened this issue Aug 9, 2020 · 1 comment · Fixed by #617
Assignees
@HalidOdat
Labels
bug Something isn't working execution Issues or PRs related to code execution
Milestone
v0.10.0

Comments

@elasmojs
Copy link
Contributor

elasmojs commented Aug 9, 2020 •
edited by HalidOdat
Loading

Hi,
1.

console.log(3n > 5); // expected output: false

Results in panic

console.log('ab' > 'aa'); expected output: true, got: false
@elasmojs elasmojs added the bug Something isn't working label Aug 9, 2020
@HalidOdat HalidOdat added the execution Issues or PRs related to code execution label Aug 9, 2020
@HalidOdat
Copy link
Member

Yes. the relation operators (>, <, <=, >=) are not spec complaint.

@HalidOdat HalidOdat self-assigned this Aug 9, 2020
@HalidOdat HalidOdat changed the title Unexpected results in 'greater than' Fix abstract relational comparison operators (<, <=, > and >=) Aug 9, 2020
@HalidOdat HalidOdat mentioned this issue Aug 9, 2020
Merged
@HalidOdat HalidOdat added this to the v0.10.0 milestone Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HalidOdat HalidOdat

Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

Fix abstract relational comparison (<, >, <= and =>) boa-dev/boa
2 participants
@HalidOdat @elasmojs