Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map.prototype.values() method not implemented #845

Closed
croraf opened this issue Oct 11, 2020 · 1 comment · Fixed by #874
Closed

Map.prototype.values() method not implemented #845

croraf opened this issue Oct 11, 2020 · 1 comment · Fixed by #874
Labels
enhancement New feature or request

Comments

@croraf
Copy link
Contributor

croraf commented Oct 11, 2020

ECMASCript feature
https://www.ecma-international.org/ecma-262/11.0/index.html#sec-map.prototype.values

Example code

const map1 = new Map();

map1.set('0', 'foo');
map1.set(1, 'bar');

const iterator1 = map1.values();

console.log(iterator1.next().value);
// expected output: "foo"

console.log(iterator1.next().value);
// expected output: "bar"
@croraf croraf added the enhancement New feature or request label Oct 11, 2020
@JohnDoneth
Copy link
Contributor

JohnDoneth commented Oct 12, 2020

I have that exact code working in a test on a branch. Implementation needs more work though. I will submit a PR when it's ready for review.

Looks like #847 should address this once finished by changing the iterator Kind to Value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants