Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report non existent file #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fperrin
Copy link
Contributor

@fperrin fperrin commented Dec 5, 2019

Hi Bryan,

Currently rflint doesn't report an error when run on a non-existent file, or a file it can't open for some other reason, only giving a message on stderr. This changes that behaviour, by going through RfLint.report to report the error. As a result the error message is formatted according to the --format option and update the exit code.

There doesn't seem to be any reference to that file in git
history
@fperrin
Copy link
Contributor Author

fperrin commented Feb 4, 2020

Hi @boakley ,

Can I also prod you to have a look at this PR?
Again, if there is anything I can do to help you review it, please tell me. I actually have a few more changes I'd like to submit, so if I can make your job easier don't hesitate, that'll make the process more enjoyable for all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant