Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report duplicate variable definition #71

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Report duplicate variable definition #71

merged 1 commit into from
Jan 31, 2020

Conversation

fperrin
Copy link
Contributor

@fperrin fperrin commented Dec 5, 2019

Hi Bryan,

This adds checking for variables defined twice (in the same table). Robot would silently ignore the second definition (or a second definition that only differ by case, whitespace or extra _).

@fperrin
Copy link
Contributor Author

fperrin commented Jan 31, 2020

Hi @boakley ,

Are you interested in this (and the other couple of open PR)?
Of course I understand you may not have much time to spend on rflint, is there something I can do to make your reviewing task easier?

@fperrin fperrin requested a review from boakley January 31, 2020 10:58
boakley
boakley approved these changes Jan 31, 2020
View reviewed changes
Copy link
Owner

@boakley boakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me. Thanks!

@boakley boakley merged commit 68fbc77 into boakley:master Jan 31, 2020
@bollenn
Copy link
Contributor

bollenn commented Jun 4, 2020

Seems this MR throws errors for duplicate Metadata

@bollenn bollenn mentioned this pull request Jun 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boakley boakley boakley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fperrin @bollenn @boakley