Add optional index parameter to RSyntaxTextArea.appendFoldingMenu() #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #565 +/- ##
=========================================
Coverage 74.63% 74.63%
- Complexity 6881 6882 +1
=========================================
Files 178 178
Lines 30264 30266 +2
Branches 3912 3912
=========================================
+ Hits 22588 22590 +2
Misses 5855 5855
Partials 1821 1821 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
This would allow inheritors of RSyntaxTextArea to insert folding menu at a preferred index, after PopupMenu is initialized because now it can only insert the Menu to the end.
Would solve the workaround introduced in skylot/jadx#2234