Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on chart doesn't open commit version #61

Closed
josephgardner opened this issue Jun 9, 2022 · 4 comments
Closed

Clicking on chart doesn't open commit version #61

josephgardner opened this issue Jun 9, 2022 · 4 comments
Assignees
@bobheadxi
Labels
bug Something isn't working

Comments

@josephgardner
Copy link

josephgardner commented Jun 9, 2022 •
edited
Loading

I've updated my template to version 1.1.0 by re-running generate,

gobenchdata web generate .

However clicking points on the graph no longer launches the repo URL.

Running serve exhibits the same behavior,

gobenchdata web serve

Are changes to the config required to upgrade the web template?
@bobheadxi
Copy link
Owner

bobheadxi commented Jun 11, 2022 •
edited
Loading

Hey! Do you mind sharing your config so I can attempt to reproduce? What version of the template are you attempting to upgrade from?

The demo at https://gobenchdata.bobheadxi.dev/, which is generated from v1.1.0, appears to have click-to-commit working correctly

@bobheadxi bobheadxi added the question Further information is requested label Jun 11, 2022
@josephgardner
Copy link
Author

I'll try to reproduce with a fresh install and report back.

@bobheadxi
Copy link
Owner

I was able to reproduce this actually, investigating!

@bobheadxi bobheadxi added bug Something isn't working and removed question Further information is requested labels Jun 12, 2022
@bobheadxi bobheadxi self-assigned this Jun 12, 2022
@bobheadxi
Copy link
Owner

bobheadxi commented Jun 12, 2022 •
edited
Loading

Should be fixed by be312a9 :)

Released in https://github.com/bobheadxi/gobenchdata/releases/tag/v1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobheadxi bobheadxi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josephgardner @bobheadxi