Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup code #3

Merged
merged 2 commits into from
Feb 25, 2013
Merged

cleanup code #3

merged 2 commits into from
Feb 25, 2013

Conversation

stdweird
Copy link

please check the TODOs

boegel
boegel reviewed Feb 24, 2013
View reviewed changes
easybuild/tools/parallelbuild.py
@@ -134,13 +133,13 @@ def create_job(build_command, easyconfig, output_dir="", conn=None, ppn=None):
return job


def get_instance(easyconfig, robot_path=None):
def get_easyblock_instance(easyconfig, robot_path=None):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Y u break API?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which API?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Touché. :P

boegel added a commit that referenced this pull request Feb 25, 2013
@boegel
Merge pull request #3 from stdweird/templating_for_job_regtest
4a6255b 
cleanup code
@boegel boegel merged commit 4a6255b into boegel:templating_for_job_regtest Feb 25, 2013
boegel pushed a commit that referenced this pull request Feb 28, 2013
@fgeorgatos
Merge pull request #3 from boegel/457_fix_EBDEVEL_modulefiles
b8a9f8d 
use quote_str function in set_environment - fixes issue with develop modules
boegel pushed a commit that referenced this pull request Apr 1, 2013
@stdweird
Merge pull request #3 from boegel/toolchain_176
fe5bb18 
restructure defined (parts of) toolchains in easybuild.toolchains package
boegel pushed a commit that referenced this pull request Apr 13, 2013
@gribozavr
Merge pull request #3 from boegel/clang-toolchains
cd4635e 
fix module load unit test + one very minor enhancement
boegel pushed a commit that referenced this pull request Feb 11, 2014
@pescobar
Merge pull request #3 from boegel/modules-unload-deps
cdf7507 
don't include 'if is-loaded' guard when recursive module unloading is requested
boegel pushed a commit that referenced this pull request Aug 4, 2014
Merge pull request #3 from boegel/imkl_fftw_mpi_fix
155e75b 
remove duplicate code in handling of FFTW cdft libs
boegel pushed a commit that referenced this pull request Feb 12, 2015
@pforai
Merge pull request #3 from boegel/support_lua_modfiles
385e325 
correctly handle .lua filename suffix and comments
boegel pushed a commit that referenced this pull request Jun 4, 2015
@sntgluca @rjeschmi
Added first version of experimental support for package_step (based o…
22e28e5 
…n code by Marc Litherland)

Update easyblock.py

Bug fixes round #1

bugfixing round #2

Bugfixes round #3

Bugfixes round #4

Bugfixes #5. Rewritten map() as list comprehension. Still not available as an optional parameter
boegel pushed a commit that referenced this pull request Jun 8, 2015
@riccardomurri
Merge pull request #3 from boegel/gc3pie
eb3ec9e 
sync with develop
boegel pushed a commit that referenced this pull request Jun 18, 2015
Merge pull request #3 from boegel/subtoolchain_searching
aed1020 
use minimally_resolve_dependencies from main.py
boegel pushed a commit that referenced this pull request Jul 7, 2015
@rjeschmi
Merge pull request #3 from boegel/feature_package_step_w_fpm
0d594d0 
don't skip package_step, add --package option, group package-related options together
boegel pushed a commit that referenced this pull request Jul 13, 2015
@Caylo
Merge pull request #3 from boegel/generic-easyblock-docs-issue636
d452321 
sync with develop
boegel pushed a commit that referenced this pull request Oct 28, 2015
@geimer
Merge pull request #3 from boegel/symlink_permissions
95c93cd 
add test for adjust_permissions
boegel pushed a commit that referenced this pull request Apr 1, 2016
@valtandor
Merge pull request #3 from boegel/availmem
3a72d29 
fix mocking of 'sysctl -n hw.memsize' in systemtools tests
boegel pushed a commit that referenced this pull request Nov 6, 2016
@akesandgren
Merge pull request #3 from boegel/add-ieee-754-conformance-as-option
a95d91c 
sync with develop & resolve conflicts
boegel pushed a commit that referenced this pull request Mar 7, 2017
@bartoldeman
Merge pull request #3 from boegel/fix_modaltsoftname_sanity_check
7ec155f 
enhance test_toy_modaltsoftname
boegel pushed a commit that referenced this pull request Mar 30, 2017
@mboisson
Merge pull request #3 from rjeschmi/compressed_patch
1a04308 
Compressed patch
boegel pushed a commit that referenced this pull request Aug 21, 2017
@damianam
Merge pull request #3 from boegel/backup_modules
8163498 
clean up back_up_file implementation & test
boegel pushed a commit that referenced this pull request Jan 4, 2018
@ebagrenrut
Merge pull request #3 from boegel/env-modules-4
d6dbdda 
update test_load, Modules v4.0 does not reload already loaded modules
boegel pushed a commit that referenced this pull request Apr 19, 2018
@shahzebsiddiqui
Merge pull request #3 from boegel/package_singularity
5140d72 
reworked implementation of Singularity integration
boegel pushed a commit that referenced this pull request Nov 21, 2018
@migueldiascosta
Merge pull request #3 from boegel/list_prs
4ece0b2 
appease the Hound
boegel pushed a commit that referenced this pull request Aug 9, 2019
@edmondac
Merge pull request #3 from boegel/checksums-itemdict
7928a38 
sync branch with develop (& sync conflicts)
boegel pushed a commit that referenced this pull request Mar 20, 2020
@casparvl
Merge pull request #3 from easybuilders/develop
dab9e64 
Bringing our develop branch up to date
boegel pushed a commit that referenced this pull request Apr 8, 2020
@victorusu
Merge pull request #3 from victorusu/lowercase-name-scheme
dc51f55 
Adding the lowercase module name scheme
boegel pushed a commit that referenced this pull request Aug 19, 2020
@Flamefire
Merge pull request #3 from boegel/fix_git_patch_permissions
694999d 
enhance test for apply_patch to also cover applying patches with git
boegel pushed a commit that referenced this pull request Nov 30, 2020
@deniskristak
Merge pull request #3 from deniskristak/feature/specsfile-devel
be5bf5c 
Feature/specsfile devel
boegel pushed a commit that referenced this pull request Sep 11, 2021
@nordmoen
Merge pull request #3 from boegel/show_progress
5c3bd50 
use random spinner in progress bar
boegel pushed a commit that referenced this pull request Sep 13, 2021
@branfosj
Merge pull request #3 from boegel/20210912083227_new_pr_WpboXfBqPF
59a9c81 
reorder progress bar components
boegel pushed a commit that referenced this pull request Apr 6, 2024
@lexming
Merge pull request #3 from boegel/extension-run
c2298d7 
enhance install_extension_substep to support passing down (named) arguments
boegel pushed a commit that referenced this pull request May 30, 2024
@Micket
Merge pull request #3 from boegel/cmdlog
8f4b323 
minor tweaks to dumping of `env.sh` + `run.sh` helper scripts in `run_shell_cmd` + enhance test to verify they're working as intended
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stdweird @boegel