Bootstrap #4
Merged
Bootstrap #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mmand line options
…ting add unit tests for --avail-easyconfig-params and --list-easyblocks command line options
… to test cmdline options that require a set of easyblocks
…ting fix broken unit tests
bump version to v1.2.0
Conflicts: easybuild/tools/version.py
| # figure out EasyBuild version | ||
| # NOTE: we can't rely on importing VERSION, because other EasyBuild installations may be in sys.path | ||
| # TODO checking the output is not a garantee for anything (eg imagine the latest eb is already on your system, just not as module) |
There was a problem hiding this comment.
actually, with the sys.path magic below, we are sure we're checking the just installed EasyBuild version
Only, this check needs to be done below the sys.path stuff, and then also doesn't have to rely on os.system anymore...
| @@ -52,7 +52,8 @@ def det_lib_path(): | |||
|
|
|||
| def find_egg_dir_for(path, pkg): | |||
| """Find full path of egg dir for given package.""" | |||
|
|
|||
| # TODO check pkg_resource.require and see if it can replace this function | |||
| # TODO pkg_resource.require will also adjust the sys.path properly | |||
There was a problem hiding this comment.
No, because then we loose control over the path where the package is found.
We know where the package that we want to use is, and we want/need to use that specific installation, not another one.
boegel
pushed a commit
that referenced
this pull request
Sep 2, 2013
…ma_specially 602 handle lists indicated with comma specially
boegel
pushed a commit
that referenced
this pull request
Jul 7, 2014
clean up support for --filter-deps + add unit tests
boegel
pushed a commit
that referenced
this pull request
Feb 12, 2015
make sure Lmod is used as modules tool when generating module files in Lua syntax
boegel
pushed a commit
that referenced
this pull request
Jun 4, 2015
boegel
pushed a commit
that referenced
this pull request
Jun 9, 2015
make unit test suite pass, rename JobServer to JobBackend, fix default for --job-bakcend
boegel
pushed a commit
that referenced
this pull request
Aug 5, 2015
sync with develop & resolve conflict
boegel
pushed a commit
that referenced
this pull request
Dec 2, 2015
use None as default value for whatis + minor style fixes
boegel
pushed a commit
that referenced
this pull request
Mar 17, 2017
rename parse_raw_path_* methods to interpret_raw_path_*, add dedicated tests for them + fix some bugs
boegel
pushed a commit
that referenced
this pull request
Aug 21, 2017
cleanup & tests for find_backup_name_candidate & move_file
boegel
pushed a commit
that referenced
this pull request
Jan 5, 2018
disable testing of bootstrap script when Modules v4 is used as modules tool
boegel
pushed a commit
that referenced
this pull request
Apr 2, 2018
use DEFAULT_OPT_LEVEL constant + fix minor style issues
boegel
pushed a commit
that referenced
this pull request
Apr 19, 2018
style fixes to make Hound CI happy
boegel
pushed a commit
that referenced
this pull request
Nov 22, 2018
ensure ordered output in message printed by --list-prs, drop unused GITHUB_MAX_PER_PAGE from _postprocess_list_prs
boegel
pushed a commit
that referenced
this pull request
Sep 12, 2021
add configuration option to allow disabling progress bar
boegel
pushed a commit
that referenced
this pull request
Sep 30, 2021
tweak GPU part of output produced by --show-system-info
boegel
pushed a commit
that referenced
this pull request
May 22, 2024
move `CWD_NOTFOUND_ERROR` constant to `tools.build_log`
boegel
pushed a commit
that referenced
this pull request
Jun 5, 2024
fix handling of specified command environment in `create_cmd_scripts` + add test for env option in `run_shell_cmd`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had not enough time to actually provide code for the TODOs, but take a look at pkg_resource.require, it should replace most of the find_egg/regexp code
i also found a typo in an EB env var