Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for plasma 6 #13

Open
chicco-carone opened this issue Dec 3, 2023 · 109 comments
Open

Add support for plasma 6 #13

chicco-carone opened this issue Dec 3, 2023 · 109 comments

Comments

@chicco-carone
Copy link

I just finished updating to plasma 6 beta 1 and this style is not present anymore in the settings since it has to be ported to qt6.

@DexterHaxxor
Copy link

To be honest, it would be a good idea to rebase this style on upstream Breeze, because that has been getting a lot of love recently and rewriting this to Qt6 in this state doesn't seem like a great idea.

@boehs
Copy link
Owner

boehs commented Jan 7, 2024

#2

@edpil02
Copy link

edpil02 commented Jan 21, 2024

I made a port to QT6 4 months ago. Luwx#200 (comment)
Still have no major issue after plasma rc1 update , but I keep trying to clean up the code.

@boehs
Copy link
Owner

boehs commented Jan 21, 2024

@edpil02 if you open source it or email me a patch (my email is evan (the at goes here) boehs.org) I’m more than happy to merge it here

@edpil02
Copy link

edpil02 commented Jan 22, 2024

I planned to send you a patch since my port is based on your repository and I wanted a code review cause I'm not a programmer , after dealing with some qt6 depredications.

At the same time klassy developer: https://github.com/paulmcauley/klassy is ready to add lighty options in his code and I think he will accept help.
I wonder if this would be a better solution rather than lightly which is no longer maintained.
At my modest level I will try to start with “transparent dolphin view.”

@alba4k
Copy link

alba4k commented Feb 16, 2024

@edpil02 Could you please publish the source code, or even just a lightly.so? I'd really love to check it out

Also I don't see how klassy could be an alternative, as that doesnt currently support qt6 either

@boehs
Copy link
Owner

boehs commented Feb 17, 2024

I’m considering the possibility of placing a bounty on this. What would people be willing to contribute?

@alba4k
Copy link

alba4k commented Feb 17, 2024

Not that much, but I could consider putting 5$ into it

@edpil02
Copy link

edpil02 commented Feb 17, 2024

I'm still spending time reviewing the code because there are still changes in qt6
With qt6.5 I had no problem.
With qt.6.6 I noticed while doing tests after my last post that the opacity had disappeared in the dolphin sidebar.
A sent two bugs report : https://bugreports.qt.io/browse/QTBUG-122290
It was only yesterday that I realized that it was not a problem of apacity but that it was necessary to change a Boolean function in lightly.
I repeat, I am a beginner learning Qt...
My distro will move to qt6.6.2 if there is no change I will send the code to Boehs.

@edpil02
Copy link

edpil02 commented Feb 17, 2024

Good news, I managed to get my opacity slider to work again.
I hope not to have new changes in a few days when my distro is on Qt6.6.2
screen

@alba4k
Copy link

alba4k commented Feb 17, 2024

@edpil02 that is looking great

Would you be able to test whether qt6ct is able to see the theme? Also, when can we hope for your work to become publicly avaiable?

@edpil02
Copy link

edpil02 commented Feb 17, 2024

See the screenshot , qt6ct (i dont use it) seems to see the theme.
As I said my distro will upgrade to the new version of qt6 in 3 days and if that goes well I will send a patch to Boehs
for review and a merge.
qt6ct

@alba4k
Copy link

alba4k commented Feb 17, 2024

That's awesome!

btw, qt6ct just exists to make qt handling easier outside of plasma, so it would make sense for you not to be using it

@edpil02
Copy link

edpil02 commented Feb 20, 2024

@alba4k . Done . I sent a tarball to Boehs for a merge if it's possible.

@boehs
Copy link
Owner

boehs commented Feb 21, 2024

I can confirm that I have received the patched tarball, I will review it shortly.

@alba4k
Copy link

alba4k commented Feb 24, 2024

I was wondering

Do you know if it would be possible to get control on the AUR package?

https://aur.archlinux.org/packages/lightly-qt

@chicco-carone
Copy link
Author

I was wondering

Do you know if it would be possible to get control on the AUR package?

https://aur.archlinux.org/packages/lightly-qt

There is already the lightly-boehs-git package on the aur

@DexterHaxxor
Copy link

As the former maintainer of that package, no, there isn't, I've deleted it because the lightly-git package points to this repo.

@alba4k
Copy link

alba4k commented Feb 24, 2024

I see, thanks!

Also, why does the -git version have so many extra dependencies?
immagine

@chicco-carone
Copy link
Author

As the former maintainer of that package, no, there isn't, I've deleted it because the lightly-git package points to this repo.

That's why i couldn't find it. I thought that the lightly-git was the git version of the original version

@alba4k
Copy link

alba4k commented Feb 28, 2024

@boehs did you manage to start taking a look at their code? sorry to bother 😅

@boehs
Copy link
Owner

boehs commented Feb 28, 2024 via email

@boehs
Copy link
Owner

boehs commented Feb 28, 2024

I have opened a PR at #16 so, if you should wish, you can test the code yourself. Aside from testing, I have asked for edpil02's preferred name and email for the commit

@boehs
Copy link
Owner

boehs commented Feb 28, 2024

I see, thanks!

Also, why does the -git version have so many extra dependencies? immagine

I do not maintain the AUR package.

Edit: And at this time I am not interested in doing so.

@boehs
Copy link
Owner

boehs commented Feb 28, 2024

One question I especially need to answer is if this code is still functional on KDE 5.27. If it's not, a decision needs to be made:

  • Fully switch to Qt 6 only
    • If so, when? Now?
  • Maintain two separate branches and request packages include code to switch to the correct brach for the build
  • Annotate the incompatible code with ifdefs of some sort

Because I suppose I am now the benevolent dictator, I'm inclined to opt for option A, but I am open to other opinions

@alba4k
Copy link

alba4k commented Feb 28, 2024

How about C? a cmake flag like -DUSE_QT6=OFF/ON could be used (this is what adwaita seems to do)

@edpil02
Copy link

edpil02 commented Feb 29, 2024

@alba4k
I thought about using this flag for compatibility with plasma5.
But just to make a code compilable with Qt6 I believe that there are at least fifty lines to change without counting that it will certainly be necessary to rewrite certain parts that Qt declares obsolete.
And even when the code compiled, the configs did not appear in Plasma 6. I had to look in the Breeze code to find a solution.
I don't think it was worth it.

But I think Boehs is better than me to decide on the right solution and improve the code.

@SakiKarened
Copy link

image
With lastest commit it doesn't seem to compile

@edpil02
Copy link

edpil02 commented Feb 29, 2024

This is what I said above, I added 1 files
lightlystyleconfig.json

I
Buils fine for me .

 DESTDIR=/builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64
+ /usr/bin/cmake --install redhat-linux-build
-- Install configuration: "Debug"
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/share/color-schemes/Lightly.colors
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/lib64/qt6/plugins/styles/lightly6.so
-- Set non-toolchain portion of runtime path of "/builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/lib64/qt6/plugins/styles/lightly6.so" to ""
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/share/kstyle/themes/lightly.themerc
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/lib64/qt6/plugins/kstyle_config/lightlystyleconfig.so
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/share/applications/lightlystyleconfig.desktop
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/bin/lightly-settings6
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/share/icons/hicolor/scalable/apps/lightly-settings.svgz
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/lib64/liblightlycommon6.so.6.80
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/lib64/liblightlycommon6.so.6
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/lib64/qt6/plugins/org.kde.kdecoration2/org.kde.lightly.so
-- Set non-toolchain portion of runtime path of "/builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/lib64/qt6/plugins/org.kde.kdecoration2/org.kde.lightly.so" to ""
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/share/kservices6/lightlydecorationconfig.desktop
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/lib64/qt6/plugins/org.kde.kdecoration2.kcm/kcm_lightlydecoration.so
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/share/applications/kcm_lightlydecoration.desktop
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/lib64/cmake/Lightly/LightlyConfig.cmake
-- Installing: /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/lib64/cmake/Lightly/LightlyConfigVersion.cmake
Processing files: lightly-qt6-0.4.1-5.fc41.x86_64
Executing(%doc): /bin/sh -e /var/tmp/rpm-tmp.KrqGMd
+ umask 022
+ cd /builddir/build/BUILD
+ cd Lightly-0.4.1
+ DOCDIR=/builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/share/doc/lightly-qt6
+ export LC_ALL=
+ LC_ALL=
+ export DOCDIR
+ /usr/bin/mkdir -p /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/share/doc/lightly-qt6
+ cp -pr /builddir/build/BUILD/Lightly-0.4.1/AUTHORS /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/share/doc/lightly-qt6
+ cp -pr /builddir/build/BUILD/Lightly-0.4.1/README.md /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/share/doc/lightly-qt6
+ RPM_EC=0
++ jobs -p
+ exit 0
Executing(%license): /bin/sh -e /var/tmp/rpm-tmp.FhE7ip
+ umask 022
+ cd /builddir/build/BUILD
+ cd Lightly-0.4.1
+ LICENSEDIR=/builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/share/licenses/lightly-qt6
+ export LC_ALL=
+ LC_ALL=
+ export LICENSEDIR
+ /usr/bin/mkdir -p /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/share/licenses/lightly-qt6
+ cp -pr /builddir/build/BUILD/Lightly-0.4.1/COPYING /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64/usr/share/licenses/lightly-qt6
+ RPM_EC=0
++ jobs -p
+ exit 0
Provides: application() application(kcm_lightlydecoration.desktop) application(lightlystyleconfig.desktop) cmake(Lightly) = 6.80 cmake(lightly) = 6.80 liblightlycommon6.so.6()(64bit) lightly-qt6 = 0.4.1-5.fc41 lightly-qt6(x86-64) = 0.4.1-5.fc41
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires: cmake-filesystem(x86-64) libKF6ColorScheme.so.6()(64bit) libKF6ConfigCore.so.6()(64bit) libKF6ConfigGui.so.6()(64bit) libKF6CoreAddons.so.6()(64bit) libKF6GuiAddons.so.6()(64bit) libKF6I18n.so.6()(64bit) libKF6IconThemes.so.6()(64bit) libKF6KCMUtils.so.6()(64bit) libKF6KCMUtilsCore.so.6()(64bit) libKF6Style.so.6()(64bit) libKF6WidgetsAddons.so.6()(64bit) libKF6WindowSystem.so.6()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.6)(64bit) libQt6DBus.so.6()(64bit) libQt6DBus.so.6(Qt_6)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Quick.so.6()(64bit) libQt6Quick.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.32)(64bit) libc.so.6(GLIBC_2.34)(64bit) libc.so.6(GLIBC_2.4)(64bit) libc.so.6(GLIBC_ABI_DT_RELR)(64bit) libkdecorations2.so.6()(64bit) liblightlycommon6.so.6()(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.30)(64bit) rtld(GNU_HASH)
Checking for unpackaged file(s): /usr/lib/rpm/check-files /builddir/build/BUILDROOT/lightly-qt6-0.4.1-5.fc41.x86_64

Wrote: /builddir/build/RPMS/lightly-qt6-0.4.1-5.fc41.x86_64.rpm

@OzzyHelix
Copy link

correction I just tested the latest commit latte dock builds to 81% so a port might be done sooner than I thought

@AlphaCraft9658
Copy link

Any progress? It does seem that even more people have figured it out. It would be great if we could see a full release soon, as that's one of the things keeping me from upgrading to KDE Plasma 6 just yet. Aside from the NVIDIA driver and Latte Dock, which should also soon be updated.

It's a bit concerning that this issue is being this silent and that there are no commits or anything. Is everything alright, @boehs?

@AlphaCraft9658
Copy link

Is anything happening here?

@AlphaCraft9658
Copy link

Hi,
Lightly now works on my KDE Neon but I have some display bugs:
Copie d'écran_20240325_221052

Not reproducible in Fedora

Screenshot_20240328_192542

How did you manage to compile? I want to maybe self-compile until there is a stable release, as I really want to upgrade to Plasma 6.

@hazel-bunny
Copy link

How did you manage to compile?

I package it for Fedora 40 and above in my copr using a patch from the AUR. You can enable my copr and install it from there if you're on Fedora. The spec file is available on GitHub.

@AlphaCraft9658
Copy link

How did you manage to compile?

I package it for Fedora 40 and above in my copr using a patch from the AUR. You can enable my copr and install it from there if you're on Fedora. The spec file is available on GitHub.

I'll probably try that out then. Thanks!

@OzzyHelix
Copy link

there seems to be a problem with it I can't seem to open the settings for Lightly on this fork
image

@AlphaCraft9658
Copy link

AlphaCraft9658 commented Nov 15, 2024

Any updates? It looks basically ready, but has no official release. I can use that one copr repo for now, but an official release would be great. There also appear to be some issues opening the settings. @boehs

@OzzyHelix
Copy link

this fork builds but the settings page doesn't work and we need an update on that and if the settings page will get fixed I am citing issue #36

@boehs
Copy link
Owner

boehs commented Nov 16, 2024

I'm sorry to announce that I believe this fork must be essentially deprecated, my Linux machine has been broken for months by now and VMs run very poorly on the new macOS machine. With the building issues people have had, I cannot in good conscious merge the PR code without having built it myself, and I certainly won't be able to fix that settings issue.

I see that @xuzhao9 has opened a number of pull requests to the main lightly repository. He may be interested in maintaining his own repository, or one of you may. For security, I will not officially endorse any forks, but I want to leave the repository unarchived for the next few months to discuss who, if anybody, will be next, somebody who I'm sure will do a much better job than I did. If consensus does emerge, I will amend the repository's README to make note of that. I just don't think its fair to any one of you for me to be at the reigns, paralyzed. I hope that by stepping aside a new leader can emerge.

Regardless of what happens, I'm happy that hundreds of you were able to extend the lifetime of this theme by a number of months. Peace ❤️

@OzzyHelix
Copy link

I think you should approach @xuzhao9 about continuing your work

@boehs
Copy link
Owner

boehs commented Nov 16, 2024

I don’t think it’s appropriate to thrust such responsibility upon him, all I was stating is that he’s been doing his own work. If he wishes to step up to bat, he’s free to, but I don’t want to force or pressure anybody into it, and again, I won’t be officially endorsing anything. He was mentioned, if he wants he can comment, and if he doesn’t, please leave him alone :)

@OzzyHelix
Copy link

I did just compile his zx9/kde6 branch and it works on Plasma 6.2 so I guess take that as you will he may already have the stuff needed to switch over

@OzzyHelix
Copy link

I also tested their master branch and it builds on Plasma 6.2 and the zx9/kde6 branch doesn't have transparency working fully but the main branch builds and installs

@OzzyHelix
Copy link

they have also expanded Lightly into a global theme it seems

@xuzhao9
Copy link

xuzhao9 commented Nov 17, 2024

Hi all, yes I am happy to continue the development at https://github.com/xuzhao9/Lightly. I am also using this theme on my Linux desktop personally.

There are a few GTK theme bugs we need to fix, but overall I am happy with it and I only plan to keep KDE compatibility upgrade and bugfix. I am glad to review any patches that add enhancement, too.

@OzzyHelix can you help test on https://github.com/xuzhao9/Lightly to check if the transparency has been fixed?

@OzzyHelix
Copy link

Hi all, yes I am happy to continue the development at https://github.com/xuzhao9/Lightly. I am also using this theme on my Linux desktop personally.

There are a few GTK theme bugs we need to fix, but overall I am happy with it and I only plan to keep KDE compatibility upgrade and bugfix. I am glad to review any patches that add enhancement, too.

@OzzyHelix can you help test on https://github.com/xuzhao9/Lightly to check if the transparency has been fixed?

the problem I encoutered was with the zx9/kde6 branch when I built the master branch it worked just fine

@OzzyHelix
Copy link

the master branch seems to be more updated than the zx9/kde6 branch the thing is there is someone who will probably want to build Lightly with kf5 support for qt5 apps on the AUR so we need to support both kf5 and kf6

@OzzyHelix
Copy link

@xuzhao9 I would get in contact with the AUR package maintainer and notify them that you are taking over for boehs.
https://aur.archlinux.org/packages/lightly-kf6-git

@OzzyHelix
Copy link

that way your version of Lightly can be pushed to the AUR and the chaotic aur

@AlphaCraft9658
Copy link

that way your version of Lightly can be pushed to the AUR and the chaotic aur

What about copr or even a more or less official package for Fedora?

@hazel-bunny
Copy link

What about copr or even a more or less official package for Fedora?

I'm still maintaining it, albeit with a few patches from https://github.com/Bali10050/Lightly and some of my own changes backported to Qt5. Officially the lightly package has been dropped since Fedora 39 and getting it approved again is a hassle.

@AlphaCraft9658
Copy link

What about copr or even a more or less official package for Fedora?

I'm still maintaining it, albeit with a few patches from https://github.com/Bali10050/Lightly and some of my own changes backported to Qt5. Officially the lightly package has been dropped since Fedora 39 and getting it approved again is a hassle.

Could you consider switching the base in the future, or is that not really possible or even necessary?

@hazel-bunny
Copy link

Could you consider switching the base in the future, or is that not really possible or even necessary?

I'll look into whether I can backport the Qt6 changes from https://github.com/xuzhao9/Lightly to Qt5. I'll change upstream if that's possible

@boehs
Copy link
Owner

boehs commented Nov 18, 2024

The README now notes the deprecation, and provides two suggestions on where to go next. It will continue to be updated until this repository is archived, and there will be at least two week's notice in this issue before that archival happens. @hazel-bunny have you been pushing your changes? I don't see any

@OzzyHelix
Copy link

OzzyHelix commented Nov 18, 2024

I think xuzhao9's fork might be better because it works the settings panel works and it is more closer to the original Lightly project I think. it doesn't mean that we can't pull things from boehs fork. I just think xuzhao9 is more complete

@hazel-bunny
Copy link

@hazel-bunny have you been pushing your changes? I don't see any

Patches can be found in my source RPMs for Qt5 and Qt6 . My ultimate aim is to bring most lightly modifications to newer breeze, which will be done in my fork called hacky . I doubt how much will be possible, though.

KF-Art added a commit to CereusLinuxProject/cereus-pkgs that referenced this issue Nov 30, 2024
Fork is no longer being maintained. See: boehs/Lightly#13 (comment)
From now on, Bali10050's fork will be the preferred one, at least for qt6.
@AlphaCraft9658
Copy link

Could you consider switching the base in the future, or is that not really possible or even necessary?

I'll look into whether I can backport the Qt6 changes from https://github.com/xuzhao9/Lightly to Qt5. I'll change upstream if that's possible

Has anything happened yet?

@FantasyPvP
Copy link

Could you consider switching the base in the future, or is that not really possible or even necessary?

I'll look into whether I can backport the Qt6 changes from https://github.com/xuzhao9/Lightly to Qt5. I'll change upstream if that's possible

Has anything happened yet?

i dont think so. the other fork hasn't had a commit in 5 months (as far as i can see correct me if im wrong) . I'm personally using https://github.com/Bali10050/Lightly which seems to be receiving regular commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests