-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for plasma 6 #13
Comments
To be honest, it would be a good idea to rebase this style on upstream Breeze, because that has been getting a lot of love recently and rewriting this to Qt6 in this state doesn't seem like a great idea. |
I made a port to QT6 4 months ago. Luwx#200 (comment) |
@edpil02 if you open source it or email me a patch (my email is evan (the at goes here) boehs.org) I’m more than happy to merge it here |
I planned to send you a patch since my port is based on your repository and I wanted a code review cause I'm not a programmer , after dealing with some qt6 depredications. At the same time klassy developer: https://github.com/paulmcauley/klassy is ready to add lighty options in his code and I think he will accept help. |
@edpil02 Could you please publish the source code, or even just a Also I don't see how klassy could be an alternative, as that doesnt currently support qt6 either |
I’m considering the possibility of placing a bounty on this. What would people be willing to contribute? |
Not that much, but I could consider putting 5$ into it |
I'm still spending time reviewing the code because there are still changes in qt6 |
That's awesome! btw, qt6ct just exists to make qt handling easier outside of plasma, so it would make sense for you not to be using it |
@alba4k . Done . I sent a tarball to Boehs for a merge if it's possible. |
I can confirm that I have received the patched tarball, I will review it shortly. |
I was wondering Do you know if it would be possible to get control on the AUR package? |
There is already the lightly-boehs-git package on the aur |
As the former maintainer of that package, no, there isn't, I've deleted it because the lightly-git package points to this repo. |
That's why i couldn't find it. I thought that the lightly-git was the git version of the original version |
@boehs did you manage to start taking a look at their code? sorry to bother 😅 |
Briefly. My Linux machine is inaccessible right now so I intend to setup a
VM to test, but I likely won't have anything before next week.
… Message ID: ***@***.***>
|
I have opened a PR at #16 so, if you should wish, you can test the code yourself. Aside from testing, I have asked for edpil02's preferred name and email for the commit |
One question I especially need to answer is if this code is still functional on KDE 5.27. If it's not, a decision needs to be made:
Because I suppose I am now the benevolent dictator, I'm inclined to opt for option A, but I am open to other opinions |
How about C? a cmake flag like |
@alba4k But I think Boehs is better than me to decide on the right solution and improve the code. |
This is what I said above, I added 1 files I
|
correction I just tested the latest commit latte dock builds to 81% so a port might be done sooner than I thought |
It's a bit concerning that this issue is being this silent and that there are no commits or anything. Is everything alright, @boehs? |
Is anything happening here? |
Any updates? It looks basically ready, but has no official release. I can use that one copr repo for now, but an official release would be great. There also appear to be some issues opening the settings. @boehs |
this fork builds but the settings page doesn't work and we need an update on that and if the settings page will get fixed I am citing issue #36 |
I'm sorry to announce that I believe this fork must be essentially deprecated, my Linux machine has been broken for months by now and VMs run very poorly on the new macOS machine. With the building issues people have had, I cannot in good conscious merge the PR code without having built it myself, and I certainly won't be able to fix that settings issue. I see that @xuzhao9 has opened a number of pull requests to the main lightly repository. He may be interested in maintaining his own repository, or one of you may. For security, I will not officially endorse any forks, but I want to leave the repository unarchived for the next few months to discuss who, if anybody, will be next, somebody who I'm sure will do a much better job than I did. If consensus does emerge, I will amend the repository's README to make note of that. I just don't think its fair to any one of you for me to be at the reigns, paralyzed. I hope that by stepping aside a new leader can emerge. Regardless of what happens, I'm happy that hundreds of you were able to extend the lifetime of this theme by a number of months. Peace ❤️ |
I think you should approach @xuzhao9 about continuing your work |
I don’t think it’s appropriate to thrust such responsibility upon him, all I was stating is that he’s been doing his own work. If he wishes to step up to bat, he’s free to, but I don’t want to force or pressure anybody into it, and again, I won’t be officially endorsing anything. He was mentioned, if he wants he can comment, and if he doesn’t, please leave him alone :) |
I did just compile his zx9/kde6 branch and it works on Plasma 6.2 so I guess take that as you will he may already have the stuff needed to switch over |
I also tested their master branch and it builds on Plasma 6.2 and the zx9/kde6 branch doesn't have transparency working fully but the main branch builds and installs |
they have also expanded Lightly into a global theme it seems |
Hi all, yes I am happy to continue the development at https://github.com/xuzhao9/Lightly. I am also using this theme on my Linux desktop personally. There are a few GTK theme bugs we need to fix, but overall I am happy with it and I only plan to keep KDE compatibility upgrade and bugfix. I am glad to review any patches that add enhancement, too. @OzzyHelix can you help test on https://github.com/xuzhao9/Lightly to check if the transparency has been fixed? |
the problem I encoutered was with the zx9/kde6 branch when I built the master branch it worked just fine |
the master branch seems to be more updated than the zx9/kde6 branch the thing is there is someone who will probably want to build Lightly with kf5 support for qt5 apps on the AUR so we need to support both kf5 and kf6 |
@xuzhao9 I would get in contact with the AUR package maintainer and notify them that you are taking over for boehs. |
that way your version of Lightly can be pushed to the AUR and the chaotic aur |
What about copr or even a more or less official package for Fedora? |
I'm still maintaining it, albeit with a few patches from https://github.com/Bali10050/Lightly and some of my own changes backported to Qt5. Officially the lightly package has been dropped since Fedora 39 and getting it approved again is a hassle. |
Could you consider switching the base in the future, or is that not really possible or even necessary? |
I'll look into whether I can backport the Qt6 changes from https://github.com/xuzhao9/Lightly to Qt5. I'll change upstream if that's possible |
The README now notes the deprecation, and provides two suggestions on where to go next. It will continue to be updated until this repository is archived, and there will be at least two week's notice in this issue before that archival happens. @hazel-bunny have you been pushing your changes? I don't see any |
I think xuzhao9's fork might be better because it works the settings panel works and it is more closer to the original Lightly project I think. it doesn't mean that we can't pull things from boehs fork. I just think xuzhao9 is more complete |
Patches can be found in my source RPMs for Qt5 and Qt6 . My ultimate aim is to bring most lightly modifications to newer breeze, which will be done in my fork called hacky . I doubt how much will be possible, though. |
Fork is no longer being maintained. See: boehs/Lightly#13 (comment) From now on, Bali10050's fork will be the preferred one, at least for qt6.
Has anything happened yet? |
i dont think so. the other fork hasn't had a commit in 5 months (as far as i can see correct me if im wrong) . I'm personally using https://github.com/Bali10050/Lightly which seems to be receiving regular commits |
I just finished updating to plasma 6 beta 1 and this style is not present anymore in the settings since it has to be ported to qt6.
The text was updated successfully, but these errors were encountered: