Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test script doesn't throw an error when it encounters one #338

Closed
marsella opened this issue Nov 26, 2021 · 1 comment · Fixed by #361
Closed

Test script doesn't throw an error when it encounters one #338

marsella opened this issue Nov 26, 2021 · 1 comment · Fixed by #361

Comments

@marsella
Copy link
Contributor

I think that the test-zeekoe.py script does not correctly handle failed cases. The behavior I expect is that if a command causes an error (e.g. establish fails due to reorg), the script should stop with an error return type. I think this is necessary for it to be a useful part of the CI.

The current behavior seems to be to log the error and continue. I observed this (an establish failure didn't stop the script from trying to pay and close), but didn't take a screenshot.

@marsella
Copy link
Contributor Author

marsella commented Jan 6, 2022

I improved error logging a little bit in #344 but confirmed this behavior: non-fatal errors do not get reported correctly from the test script to the CI.

A complete solution to this might be blocking on #91, because zeekoe currently reports both non-necessary info and errors on stderr, so the test script cannot distinguish between them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant