From 857221f1fd9b54732edac56aeafadb5f589410b6 Mon Sep 17 00:00:00 2001 From: Boni Garcia Date: Tue, 20 Jun 2023 13:42:04 +0200 Subject: [PATCH] A couple of minor smell-fix --- src/main/java/io/github/bonigarcia/wdm/online/Parser.java | 4 ++++ .../io/github/bonigarcia/wdm/versions/VersionDetector.java | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/main/java/io/github/bonigarcia/wdm/online/Parser.java b/src/main/java/io/github/bonigarcia/wdm/online/Parser.java index 667173af3..fea5bc426 100644 --- a/src/main/java/io/github/bonigarcia/wdm/online/Parser.java +++ b/src/main/java/io/github/bonigarcia/wdm/online/Parser.java @@ -40,6 +40,10 @@ public class Parser { static final Logger log = getLogger(lookup().lookupClass()); + private Parser() { + throw new IllegalStateException("Utility class"); + } + public static T parseJson(HttpClient client, String url, Class klass) throws IOException { HttpGet get = client.createHttpGet(new URL(url)); diff --git a/src/main/java/io/github/bonigarcia/wdm/versions/VersionDetector.java b/src/main/java/io/github/bonigarcia/wdm/versions/VersionDetector.java index f6356e443..c551c33d6 100644 --- a/src/main/java/io/github/bonigarcia/wdm/versions/VersionDetector.java +++ b/src/main/java/io/github/bonigarcia/wdm/versions/VersionDetector.java @@ -123,7 +123,6 @@ public Optional getDriverVersionFromRepository( // Parse JSON using GoodVersions cftUrl = config.getChromeGoodVersionsUrl(); - System.out.println(driverVersion); GoodVersions versions = Parser.parseJson(httpClient, cftUrl, GoodVersions.class); List fileteredList = versions.versions.stream() @@ -137,9 +136,9 @@ public Optional getDriverVersionFromRepository( // Parse JSON using LastGoodVersions cftUrl = config.getChromeLastGoodVersionsUrl(); - System.out.println(driverVersion); LastGoodVersions versions = Parser.parseJson(httpClient, cftUrl, LastGoodVersions.class); + return Optional.of(versions.channels.stable.version); } } catch (Exception e) {