-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record report actions #2854
Record report actions #2854
Conversation
This table will now track all actions taken on a report, like resolving it, re-opening it, suspending the reported user, et cetera, in addition to comments. When there are multiple admins, this change will make it easier to understand what actions have been taken by whom on a report.
On second thoughts, I think recording DMs sent would be unnecessarily convoluted. It might make more sense (another time) to have a different way to updating users about actions taken on reports. @bookwyrm-social/code-review could someone take a look at this? |
I can take a look in a couple of days unless someone else gets to it first, which they are very welcome to do! I've not used the admin interface but is there any way to store free text notes against a report? If so, that should be stored, and could possibly be included in a message/email to the reporter when the report is resolved? |
Now that I'm looking at it, I wonder if the chronology should be reversed 🤔 |
As the comment box is at the bottom it would be good to have the order reversed for reading consistency. |
Sorry for the long delay on a very small change! This is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks mostly good. There's a bug, and what I guess is an enhancement suggestion.
I also noticed another bug when testing this that is not caused by anything in your code (the javascript for reporting a user is a little buggy) - I'll log an Issue for that.
I'm working on the prettier complaints in #2903 |
@hughrun This has been sitting for a bit and I think it's ready to go so I'm going to go ahead and merge. Thank you for the feedback on it! |
This table will now track all actions taken on a report, like resolving it, re-opening it, suspending the reported user, et cetera, in addition to comments. When there are multiple admins, this change will make it easier to understand what actions have been taken by whom on a report.
Work:
track messaging reporter and reporteeFixes #2505