Adds management command to repair editions in bad state #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an edition is missing its work, this change allows the page to still load without a server error; this is important because otherwise the book will break every page it appears on, including the feed page.
It's rare that it will be useful, and it was a huge hassle.
axiomizer
reviewed
Aug 1, 2023
There was a problem hiding this comment.
Tested with the following steps:
- build dev instance from main branch
- update bookwyrm_edition set parent_work_id = NULL where isbn_13='9780553173253';
- navigate to the book's page and it crashes
- build dev instance from broken-editions branch
- book's parent_work_id is still NULL
- docker-compose run --rm web python manage.py repair_editions (fix typo in repair_editions.py)
- the parent_work_id is set, and there's a new entry in bookwyrm_work and bookwyrm_book with that new id
- navigate to the book's page and it doesn't crash now
- docker-compose run --rm web python manage.py test bookwyrm.tests.models.test_book_model (10 tests passed)
- docker-compose run --rm web python manage.py test bookwyrm.tests.templatetags.test_rating_tags (4 tests passed)
|
Extremely appreciate the review, thank you! |
This was referenced Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes editions are created without an associated parent work, which is Not Great, but difficult to ensure never happen. This command will match an orphan edition with a work, if there's another edition with the same unique identifiers (like ISBN), and create a new work if not. I've also added some logic to have this case fail gracefully in the UI to avoid server errors popping up all over the place.
I didn't have a chance to test this code before I had to go hang out with a cool baby so it needs more work, but should be the right idea
Fixes #2895