Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add copy button for ISBN #2915

Merged
merged 5 commits into from
Aug 2, 2023
Merged

Add copy button for ISBN #2915

merged 5 commits into from
Aug 2, 2023

Conversation

axiomizer
Copy link
Contributor

@axiomizer axiomizer commented Jul 22, 2023 •
edited
Loading

For #2892

@mouse-reeve
Copy link
Member

I think it might be easier to bring the hyphenation in a separate PR -- it's going to take me a minute to wrap my head around it, and it's going to need some revisions and it would be a shame to hold up the copy link because of that.

@axiomizer axiomizer changed the title Hyphenate ISBN numbers and add copy button Add copy button for ISBN Jul 22, 2023
@axiomizer
Copy link
Contributor Author

axiomizer commented Jul 22, 2023 •
edited
Loading

Thanks for taking a look :) I took out the hyphenation stuff

@axiomizer axiomizer mentioned this pull request Jul 25, 2023
Merged
mouse-reeve
mouse-reeve requested changes Aug 2, 2023
View reviewed changes
Copy link
Member

@mouse-reeve mouse-reeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is screen reader friendly and the checks are passing (which we talked about in the chat) it should be good to go. Thank you so much for adding it!

bookwyrm/templates/book/book_identifiers.html Outdated Show resolved Hide resolved
bookwyrm/templates/book/book_identifiers.html Show resolved Hide resolved
@axiomizer
Make copy button screen reader friendly
3ca36fe 
revert last commit because prettier was run with the wrong version
This reverts commit 5d3883c.
mouse-reeve
mouse-reeve approved these changes Aug 2, 2023
View reviewed changes
Copy link
Member

@mouse-reeve mouse-reeve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for adding this nice feature and being so patient with the janky CI and various tweaks in the review process!

@mouse-reeve mouse-reeve merged commit 73f1484 into bookwyrm-social:main Aug 2, 2023
@axiomizer
Copy link
Contributor Author

My first merged PR 😊 Thanks for your help

@soshial
Copy link

soshial commented Sep 4, 2023

Thank you so much, @axiomizer, for your efforts!
ISBNs looks is so much better now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mouse-reeve mouse-reeve mouse-reeve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@axiomizer @mouse-reeve @soshial @ignorantFid