Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for create-book #2937

Merged
merged 1 commit into from
Aug 2, 2023
Merged

Conversation

jderuiter
Copy link
Contributor

This PR addresses a couple of smaller issues when using create-book:

  • When manually adding a new edition and you do not add a new author, you're asked whether you want to add the author ['']
  • When creating a new book manually and leaving the author blank you're asked whether you want to create the author []
  • When adding a new book and possible matches are found these are not displayed as data["book"] is always set for the subjects (even when none are provided) and when a possible match is selected it is not actually set as parent_work as parent_work was sent twice in the POST request (once the selected value and once an empty hidden field)

@mouse-reeve
Copy link
Member

Thank you so much! Looks good

@mouse-reeve mouse-reeve merged commit 173d0b7 into bookwyrm-social:main Aug 2, 2023
@jderuiter jderuiter deleted the create-book-fixes branch August 25, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants