Cite author in quotations and alt text #3008
Conversation
dato
force-pushed
the
author_in_citation
branch
from
1b2d127
to
7cfdf23
Compare
| return text | ||
| author = f"{name}: " if (name := self.author_text) else "" | ||
| edition = f" ({info})" if (info := self.edition_info) else "" | ||
| return f"{author}{self.title}{edition}" |
There was a problem hiding this comment.
In this case, I think this string should be localized, by wrapping it in _(), since it is used in the UI
There was a problem hiding this comment.
I think I see what you mean, but in that case... isn't this string a bit useless in translation context, since it's fully formatted already? (with colons, e.g.—this format being what might need changes in translation).
What I mean is: to make this translatable, shouldn't we produce three un-collapsed translation strings instead?:
{author}: {title}{title} ({edition}){author}: {title} ({edition})
(At this point could also be {title} by {author} ({edition}), but that's a separate matter.)
There was a problem hiding this comment.
Ah I see what you mean, since it's formatted in previous variables, translating the final string would be basically meaningless. It would be best from a translation standpoint to enumerate fully formed strings (even though that's annoying from a code standpoint), but I don't think that's a blocker to merging, since it already isn't translated
|
|
||
| def save(self, *args: Any, **kwargs: Any) -> None: | ||
| """can't be abstract for query reasons, but you shouldn't USE it""" | ||
| if not isinstance(self, Edition) and not isinstance(self, Work): | ||
| if not isinstance(self, (Edition, Work)): |
No description provided.