Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check no missing migrations in django-tests workflow #3112

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

dato
Copy link
Contributor

@dato dato commented Nov 13, 2023


I missed a migration from #3099 (I missed it because, AFAICS, it's a no-op migration, yet Django wants it).

In this PR, I add the missing migration, plus a test so that this doesn't happen in the future. (Adding the test alone first so as to see it fail.)

@dato dato marked this pull request as ready for review November 13, 2023 22:46
@dato dato marked this pull request as draft November 13, 2023 22:57
@dato dato marked this pull request as ready for review November 13, 2023 22:59
@mouse-reeve
Copy link
Member

Good call, thank you!

@mouse-reeve mouse-reeve merged commit ab9cea1 into bookwyrm-social:main Nov 13, 2023
10 checks passed
@dato dato deleted the makemigrations_check branch November 13, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants