Faster tests with setUpTestData #3146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dato
commented
Dec 5, 2023
Pylint's `bad-classmethod-argument` is disabled for each definition to avoid rewriting the method bodies just to rename `self` → `cls`. This can be done gradually, as the setUpTestData methods are modified along the way.
Many tests break without this on newer versions of html-tidy.
dato
force-pushed
the
setup_test_data
branch
from
54f763e
to
aa67f59
Compare
dato
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django's TestCase.setUpTestData() allows us to create database fixtures once per test class, instead of once per test method. This speeds up tests considerably.¹
As per the documentation, database fixtures are created once, and roll'd-back to after each test. (Additionally, it is safe to store the resulting models as class variables, since the Python objects are deepcopy()'d from the original before each test.)
I think this could be a nice addition to the BookWyrm codebase.
(¹) On my old laptop, running the whole test suite goes down from ~20min to ~9min (on my newer desktop, it's down to 2min, which is a joy). It seems to go from ~8min to ~4min in the Github runners.