-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check version number asynchronously #3185
Changes from all commits
d6f7f76
5509941
f36af42
8be9e91
193a1c7
d287581
a1ac949
48f8ee5
4e2b8af
f7580c5
748c934
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
0.7.1 | ||
0.6.1 |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
# Generated by Django 3.2.23 on 2024-01-02 19:36 | ||
|
||
from django.db import migrations | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("bookwyrm", "0191_merge_20240102_0326"), | ||
] | ||
|
||
operations = [ | ||
migrations.RenameField( | ||
model_name="sitesettings", | ||
old_name="version", | ||
new_name="available_version", | ||
), | ||
] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# Generated by Django 3.2.23 on 2024-02-03 16:19 | ||
|
||
from django.db import migrations | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("bookwyrm", "0192_rename_version_sitesettings_available_version"), | ||
("bookwyrm", "0193_merge_20240203_1539"), | ||
] | ||
|
||
operations = [] |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{% extends 'settings/dashboard/warnings/layout.html' %} | ||
{% load i18n %} | ||
|
||
{% block warning_link %}#{% endblock %} | ||
|
||
{% block warning_text %} | ||
|
||
<form name="check-version" method="POST" action="{% url 'settings-dashboard' %}" class="is-flex is-align-items-center"> | ||
{% csrf_token %} | ||
|
||
<p class="pr-2"> | ||
{% blocktrans trimmed with current=current_version available=available_version %} | ||
Would you like to automatically check for new BookWyrm releases? (recommended) | ||
{% endblocktrans %} | ||
</p> | ||
|
||
{{ schedule_form.every.as_hidden }} | ||
{{ schedule_form.period.as_hidden }} | ||
|
||
<button class="button is-small" type="submit">{% trans "Schedule checks" %}</button> | ||
</form> | ||
|
||
{% endblock %} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,127 @@ | ||
{% extends 'settings/layout.html' %} | ||
{% load i18n %} | ||
{% load humanize %} | ||
{% load utilities %} | ||
|
||
{% block title %} | ||
{% trans "Scheduled tasks" %} | ||
{% endblock %} | ||
|
||
{% block header %} | ||
{% trans "Scheduled tasks" %} | ||
{% endblock %} | ||
|
||
{% block panel %} | ||
|
||
<div class="block content"> | ||
<h3>{% trans "Tasks" %}</h3> | ||
<div class="table-container"> | ||
<table class="table is-striped is-fullwidth"> | ||
<tr> | ||
<th> | ||
{% trans "Name" %} | ||
</th> | ||
<th> | ||
{% trans "Celery task" %} | ||
</th> | ||
<th> | ||
{% trans "Date changed" %} | ||
</th> | ||
<th> | ||
{% trans "Last run at" %} | ||
</th> | ||
<th> | ||
{% trans "Schedule" %} | ||
</th> | ||
<th> | ||
{% trans "Schedule ID" %} | ||
</th> | ||
<th> | ||
{% trans "Enabled" %} | ||
</th> | ||
</tr> | ||
{% for task in tasks %} | ||
<tr> | ||
<td> | ||
{{ task.name }} | ||
</td> | ||
<td class="overflow-wrap-anywhere"> | ||
{{ task.task }} | ||
</td> | ||
<td> | ||
{{ task.date_changed }} | ||
</td> | ||
<td> | ||
{{ task.last_run_at }} | ||
</td> | ||
<td> | ||
{% firstof task.interval task.crontab "None" %} | ||
</td> | ||
<td> | ||
{{ task.interval.id }} | ||
</td> | ||
<td> | ||
<span class="tag"> | ||
{% if task.enabled %} | ||
<span class="icon icon-check" aria-hidden="true"></span> | ||
{% endif %} | ||
{{ task.enabled|yesno }} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Currently there does not seem to be a way to disable Now, one might argue that they shouldn't be disabled, but it seems a bit odd that you have to manually turn on There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah, I agree, I think it should be a subsequent PR because celery.backend_cleanup might be the kind of the thing that it's Not Good to turn off There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. actually but now that I saw that, if someone has it running every minute, they're probably going to be displeased not to be able to stop it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess we could trigger a big scary banner if it's ever turned off. I don't think this needs to be a blocker for this PR, just wanted to note it for future improvement. |
||
</span> | ||
{% if task.name != "celery.backend_cleanup" %} | ||
<form name="unschedule-{{ task.id }}" method="POST" action="{% url 'settings-schedules' task.id %}"> | ||
{% csrf_token %} | ||
<button type="submit" class="button is-danger is-small">{% trans "Un-schedule" %}</button> | ||
</form> | ||
{% endif %} | ||
</td> | ||
</tr> | ||
{% empty %} | ||
<tr> | ||
<td colspan="2"> | ||
{% trans "No scheduled tasks" %} | ||
</td> | ||
</tr> | ||
{% endfor %} | ||
</table> | ||
</div> | ||
</div> | ||
|
||
<div class="block content"> | ||
<h3>{% trans "Schedules" %}</h3> | ||
<div class="table-container"> | ||
<table class="table is-striped is-fullwidth"> | ||
<tr> | ||
<th> | ||
{% trans "ID" %} | ||
</th> | ||
<th> | ||
{% trans "Schedule" %} | ||
</th> | ||
<th> | ||
{% trans "Tasks" %} | ||
</th> | ||
</tr> | ||
{% for schedule in schedules %} | ||
<tr> | ||
<td> | ||
{{ schedule.id }} | ||
</td> | ||
<td class="overflow-wrap-anywhere"> | ||
{{ schedule }} | ||
</td> | ||
<td> | ||
{{ schedule.periodictask_set.count }} | ||
</td> | ||
</tr> | ||
{% empty %} | ||
<tr> | ||
<td colspan="2"> | ||
{% trans "No schedules found" %} | ||
</td> | ||
</tr> | ||
{% endfor %} | ||
</table> | ||
</div> | ||
</div> | ||
|
||
{% endblock %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice-to-have (possibly in a subsequent PR) would be to link the task name to some sort of explanation of the purpose of the task and/or what it does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Periodic tasks have a
description
field which we're currently not using, but presumably would be perfect for this