Add timeouts to requests.get #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An instance of requests.get in isbn.py lacks a timeout, and this commit adds one with a default of 15 as used other places in the code, where requests.get does already have a timeout.
An instance of requests.get was missing a timeout; this commit adds a timeout of 15 as used in other places in this codebase which already have timeouts.
|
Thank you, these should definitely have timeouts! I think we should move all instances of timeouts to the one set by the environment variable, but since that would be a bigger change than this, it seems like a good call to make that a separate task. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two instances of requests.get are currently missing timeouts. Without an explicit timeout, requests.get will never time out, which can cause code to hang.
Some instances of requests.get in other parts of the code did have timeouts, in one instance configurable and in all others 15. The missing instances felt more analogous to the place where it was already 15 than the configurable one, so this PR adds timeouts of 15 in the two places that currently lack a timeout.
The phildini/bookwyrm fork is already successfully running with these changes in production, but we've done a bunch of infrastructure stuff recently as well, so I made a new fork to submit a cleaner PR to yall.