Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate apply_operation and replace with variant visitation #482

Closed
mloskot opened this issue Apr 17, 2020 · 0 comments · Fixed by #656
Closed

Deprecate apply_operation and replace with variant visitation #482

mloskot opened this issue Apr 17, 2020 · 0 comments · Fixed by #656
Labels
cat/deprecation Deprecate a feature or functionality cat/enhancement Improvements, but not fixes addressing identified bugs ext/dynamic_image boost/gil/extension/dynamic_image

Comments

@mloskot
Copy link
Member

mloskot commented Apr 17, 2020

Follow-up to #474 (comment) between @sdebionne and @simmplecoder and @mloskot

apply_operation should be marked [[deprecated]] and provided only for backward compatibility. Just use visit in modern code (no limit on arity, etc...)

there is BOOST_NO_CXX11_DECLTYPE vs BOOST_NO_CXX11_DECLTYPE_N3276
@mloskot mloskot added cat/enhancement Improvements, but not fixes addressing identified bugs ext/dynamic_image boost/gil/extension/dynamic_image cat/deprecation Deprecate a feature or functionality labels Apr 17, 2020
@mloskot mloskot mentioned this issue Apr 17, 2020
Merged
5 tasks
@marco-langer marco-langer mentioned this issue May 1, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat/deprecation Deprecate a feature or functionality cat/enhancement Improvements, but not fixes addressing identified bugs ext/dynamic_image boost/gil/extension/dynamic_image
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Deprecate apply_operation in favor of variant2::visit for any_image marco-langer/gil
1 participant
@mloskot