-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[voronoi] issue with pss() #67
Comments
@eadf have you had a chance to work on a fix for |
@vm-am I made an effort to try to figure out the edge cases, but they just kept popping up. But I will take a look at it again next week or so |
@eadf in your example, are both segments missing the circle? Would you please share the input to It seems to work okay (so far) but I believe we'd better fix this issue during the construction of the circle rather than after the fact and risk to hit more edge cases. |
1.76.0 produces this voronoi output:
1
here
pss([-985,-362],[-179,453,-238,248],[673,903,-985,-362])
finds a CE @[-2674.2,1851.9];2
here
pss([519,-635],[519,-635,342,-158],[269,-113,507,-171])
finds a CE @ [788.2,-535.1]3
here
pss([-716,412],[-716,412,999,356],[533,65,597,-23])
finds a CE @ [-784.19,-1676.38]4
in example ”primary_29.txt"
pss([-1,1], [0,1,0,0], [0,0,-1,1])
finds a CE @ [-0.59,1.41]In these examples
pss()
solves for CE solutions where the (infinite line) segments tangents the CE, but the segment falls short of reaching that tangent point.The text was updated successfully, but these errors were encountered: